particle-os/debian-forge-cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

testutil: remove unnecessary testutil.MockCmd.Restore()

Browse source 
While looking over the code I noticed that the `Restore()` helper
is not needed (and arguably wrong as it does not reset PATH).
We already use `t.TempDir()` and `t.Setenv()` as part of the
command setup so manually cleanup is not neccessary (and is today
even incomplete). So YAGNI and we can remove Restore().
This commit is contained in:
Michael Vogt 2025-07-16 10:53:52 +02:00
parent 9717980d3f
commit bb45b89d84
4 changed files with 7 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/testutil/testutil.go
View file

@ -41,10 +41,6 @@ func (mc *MockCmd) Path() string {
return filepath.Join(mc.binDir, mc.name)
}
func (mc *MockCmd) Restore() error {
return os.RemoveAll(mc.binDir)
}
func (mc *MockCmd) Calls() [][]string {
b, err := os.ReadFile(mc.Path() + ".run")
if os.IsNotExist(err) {