particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lint: Clean up golangci-lint v1.60 complaints

Browse source 
This cleans up the linting results by adding checks for
integer underflow/overflow in several places, suppressing the error in
places where it has been checked, or fixing the types when possible.
This commit is contained in:
Brian C. Lane 2025-02-13 16:49:40 -08:00 • committed by Brian C. Lane
parent 2dad1a965e
commit 0256e09031
11 changed files with 47 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/cloudapi/v2/handler.go
View file

@ -464,7 +464,13 @@ func (h *apiHandlers) getJobIDComposeStatus(jobId uuid.UUID) (ComposeStatus, err
ImageStatuses: &buildJobStatuses,
KojiStatus: &KojiStatus{},
}
/* #nosec G115 */
buildID := int(initResult.BuildID)
// Make sure signed integer conversion didn't underflow
if buildID < 0 {
err := fmt.Errorf("BuildID integer underflow: %d", initResult.BuildID)
return ComposeStatus{}, HTTPErrorWithInternal(ErrorMalformedOSBuildJobResult, err)
}
if buildID != 0 {
response.KojiStatus.BuildId = &buildID
}