From 062e38da696a678262f506aed310bba150b8b3eb Mon Sep 17 00:00:00 2001 From: Achilleas Koutsou Date: Wed, 29 Jun 2022 11:15:42 +0200 Subject: [PATCH] osbuild-package-sets: check for required cl args Print usage when one or more required arguments are omitted. Fix the error message for incorrect distro: print distroName, not distro (nil). --- cmd/osbuild-package-sets/main.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cmd/osbuild-package-sets/main.go b/cmd/osbuild-package-sets/main.go index 87f5218d0..506efbcab 100644 --- a/cmd/osbuild-package-sets/main.go +++ b/cmd/osbuild-package-sets/main.go @@ -22,11 +22,16 @@ func main() { flag.StringVar(&imageName, "image", "", "Image name") flag.Parse() + if distroName == "" || archName == "" || imageName == "" { + flag.Usage() + os.Exit(1) + } + dr := distroregistry.NewDefault() distro := dr.GetDistro(distroName) if distro == nil { - panic(fmt.Errorf("Distro %q does not exist", distro)) + panic(fmt.Errorf("Distro %q does not exist", distroName)) } arch, err := distro.GetArch(archName)