From 1ae1131fe484ded4b16b4f837742d7844a2ed504 Mon Sep 17 00:00:00 2001 From: Martin Sehnoutka Date: Tue, 7 Apr 2020 15:11:32 +0200 Subject: [PATCH] image-info: report errors from subprocess calls The subproces.check_output function hides the output of the subprocess it runs, using subprocess.run directly enable us to see the errors. --- tools/image-info | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/image-info b/tools/image-info index f0e55eea7..32d38177a 100755 --- a/tools/image-info +++ b/tools/image-info @@ -75,7 +75,14 @@ def parse_unit_files(s, expected_state): def subprocess_check_output(argv, parse_fn=None): - output = subprocess.check_output(argv, encoding="utf-8") + try: + output = subprocess.check_output(argv, encoding="utf-8") + except subprocess.CalledProcessError as e: + sys.stderr.write(f"--- Output from {argv}:\n") + sys.stderr.write(e.stdout) + sys.stderr.write("\n--- End of the output\n") + raise + return parse_fn(output) if parse_fn else output