particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

composer: seed the random number generator

Browse source 
I thought rand in Go is auto-seeded but I was wrong, see [1].
This commit adds seed initialization.

[1]: https://golang.org/pkg/math/rand/#Seed

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
This commit is contained in:
Ondřej Budai 2020-12-15 17:00:00 +01:00 • committed by Ondřej Budai
parent 973639d372
commit 1dd4eb7e38
3 changed files with 27 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/kojiapi/server.go
View file

@ -2,10 +2,12 @@
package kojiapi
import (
"crypto/rand"
"encoding/json"
"fmt"
"log"
"math/rand"
"math"
"math/big"
"net/http"
"strings"
"time"
@ -89,7 +91,11 @@ func (h *apiHandlers) PostCompose(ctx echo.Context) error {
kojiDirectory := "osbuild-composer-koji-" + uuid.New().String()
// use the same seed for all images so we get the same IDs
manifestSeed := rand.Int63()
bigSeed, err := rand.Int(rand.Reader, big.NewInt(math.MaxInt64))
if err != nil {
panic("cannot generate a manifest seed: " + err.Error())
}
manifestSeed := bigSeed.Int64()
for i, ir := range request.ImageRequests {
arch, err := d.GetArch(ir.Architecture)