diff --git a/internal/cloudapi/v2/errors.go b/internal/cloudapi/v2/errors.go index 5f480190e..4de43415d 100644 --- a/internal/cloudapi/v2/errors.go +++ b/internal/cloudapi/v2/errors.go @@ -3,11 +3,8 @@ package v2 import ( "fmt" "net/http" - "strings" "github.com/labstack/echo/v4" - - "github.com/osbuild/osbuild-composer/internal/prometheus" ) const ( @@ -302,13 +299,6 @@ func (s *Server) HTTPErrorHandler(echoError error, c echo.Context) { return } - internalError := he.Code >= http.StatusInternalServerError && he.Code <= http.StatusNetworkAuthenticationRequired - if internalError { - if strings.HasSuffix(c.Path(), "/compose") { - prometheus.ComposeFailures.Inc() - } - } - err, ok := he.Message.(detailsError) if !ok { // No service code was set, so Echo threw this error diff --git a/internal/prometheus/http_metrics.go b/internal/prometheus/http_metrics.go index e49830d73..0b2d912e1 100644 --- a/internal/prometheus/http_metrics.go +++ b/internal/prometheus/http_metrics.go @@ -14,16 +14,6 @@ var ( }) ) -var ( - // update this to count all 500s - ComposeFailures = promauto.NewCounter(prometheus.CounterOpts{ - Name: "total_failed_compose_requests", - Namespace: Namespace, - Subsystem: ComposerSubsystem, - Help: "total number of failed compose requests", - }) -) - var ( ComposeRequests = promauto.NewCounter(prometheus.CounterOpts{ Name: "total_compose_requests",