particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cloudapi: Add extra logging & improve existing

Browse source 
Use different logging levels depending on situation
Log HTTP 5xx errors to stdout with internal error details when possible
This commit is contained in:
Diaa Sami 2021-09-22 17:39:53 +02:00 • committed by Sanne Raymaekers
parent 179009fec4
commit 27ca55372a
2 changed files with 17 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/cloudapi/v2/errors.go
View file

@ -219,7 +219,14 @@ func (s *Server) HTTPErrorHandler(echoError error, c echo.Context) {
apiErr := APIError(code, sec, c)
if sec.httpStatus == http.StatusInternalServerError {
c.Logger().Errorf("Internal server error. Code: %s, OperationId: %s", apiErr.Code, apiErr.OperationId)
internalError, ok := echoError.(*echo.HTTPError)
errMsg := fmt.Sprintf("Internal server error. Code: %s, OperationId: %s", apiErr.Code, apiErr.OperationId)
if ok {
errMsg += fmt.Sprintf(", InternalError: %v", internalError)
}
c.Logger().Error(errMsg)
}
if c.Request().Method == http.MethodHead {
@ -237,6 +244,7 @@ func (s *Server) HTTPErrorHandler(echoError error, c echo.Context) {
he, ok := echoError.(*echo.HTTPError)
if !ok {
c.Logger().Errorf("ErrorNotHTTPError %v", echoError)
doResponse(ErrorNotHTTPError, c)
return
}