particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

client: drop client timeout in tests

Browse source 
A timeout doesn't make sense on this level, because it is very difficult
to estimate how long downloading rpm metadata takes. Drop it completely
in favor of higher-level timeouts in the test runner.

Fixes #601
This commit is contained in:
Lars Karlitski 2020-05-12 20:08:17 +02:00
parent d49f0fef44
commit 2ecdee6814
3 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/client/utils.go
View file

@ -11,7 +11,6 @@ import (
"net/http"
"sort"
"strconv"
"time"
)
type TestState struct {
@ -32,12 +31,10 @@ func isStringInSlice(slice []string, s string) bool {
return false
}
func setUpTestState(socketPath string, timeout time.Duration, unitTest bool) (*TestState, error) {
func setUpTestState(socketPath string, unitTest bool) (*TestState, error) {
state := TestState{unitTest: unitTest}
state.socket = &http.Client{
// TODO This may be too short/simple for downloading images
Timeout: timeout,
Transport: &http.Transport{
DialContext: func(_ context.Context, _, _ string) (net.Conn, error) {
return net.Dial("unix", socketPath)