From 322ae02f73a39573ca4c13b33d85544a53a815cd Mon Sep 17 00:00:00 2001 From: Tomas Hozza Date: Fri, 29 Jul 2022 10:37:28 +0200 Subject: [PATCH] internal/container: delete leftover dead code This issue was found by Coverity: Error: DEADCODE (CWE-561): [#def1] osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:386: cond_null: Condition "err != nil", taking false branch. Now the value of "err" is "nil". osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:390: null: At condition "err != nil", the value of "err" must be "nil". osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:390: dead_error_condition: The condition "err != nil" cannot be true. osbuild-composer-58/_build/src/github.com/osbuild/osbuild-composer/internal/container/client.go:391: dead_error_line: Execution cannot reach this statement: ".$0 = container....". 389| 390| if err != nil { 391|-> return resolvedIds{}, nil 392| } 393| --- internal/container/client.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/internal/container/client.go b/internal/container/client.go index cb05b9939..89a100812 100644 --- a/internal/container/client.go +++ b/internal/container/client.go @@ -387,10 +387,6 @@ func (cl *Client) resolveManifestList(ctx context.Context, list manifestList) (r return resolvedIds{}, fmt.Errorf("error getting manifest: %w", err) } - if err != nil { - return resolvedIds{}, nil - } - return cl.resolveRawManifest(ctx, raw) }