cloudapi: separate repositories based on package_sets

- Any repository without package_sets is added to the general `Repos`
  field of the DepsolveJob, just like before.
- Repositories with package_sets are added to the `PackageSetsRepos`
  map, indexed by the package set names.
- Repositories defined in the customizations as `PayloadRepositories`
  are considered to be associated only with the `PayloadPackageSets`
  names from the image type and are added to the `PackageSetsRepos`
  under the payload sets.

The repository collection and conversion of repository structs (from
Repository to RepoConfig) has been moved to a separate function.

internal/cloudapi/v2/v2.go

@@ -242,42 +242,10 @@ func (h *apiHandlers) PostCompose(ctx echo.Context) error {
 		if err != nil {
 			return HTTPError(ErrorUnsupportedImageType)
 		}
-		repositories := make([]rpmmd.RepoConfig, len(ir.Repositories))
-		for j, repo := range ir.Repositories {
-			repositories[j].RHSM = repo.Rhsm
 
-			if repo.Baseurl != nil {
+		repos, pkgSetsRepos, err := collectRepos(ir.Repositories, payloadRepositories, imageType.PayloadPackageSets())
-				repositories[j].BaseURL = *repo.Baseurl
+		if err != nil {
-			} else if repo.Mirrorlist != nil {
+			return err
-				repositories[j].MirrorList = *repo.Mirrorlist
-			} else if repo.Metalink != nil {
-				repositories[j].Metalink = *repo.Metalink
-			} else {
-				return HTTPError(ErrorInvalidRepository)
-			}
-		}
-
-		payloadPackageSets := imageType.PayloadPackageSets()
-		packageSetsRepositories := make(map[string][]rpmmd.RepoConfig, len(payloadPackageSets))
-
-		for _, packageSetKey := range payloadPackageSets {
-			packageSetsRepositories[packageSetKey] = make([]rpmmd.RepoConfig, len(payloadRepositories))
-			for j, repo := range payloadRepositories {
-				if repo.Baseurl != nil {
-					packageSetsRepositories[packageSetKey][j].BaseURL = *repo.Baseurl
-				} else {
-					return HTTPError(ErrorNoBaseURLInPayloadRepository)
-				}
-				if repo.GpgKey != nil {
-					packageSetsRepositories[packageSetKey][j].GPGKey = *repo.GpgKey
-				}
-				if repo.CheckGpg != nil {
-					packageSetsRepositories[packageSetKey][j].CheckGPG = *repo.CheckGpg
-				}
-				if repo.IgnoreSsl != nil {
-					packageSetsRepositories[packageSetKey][j].IgnoreSSL = *repo.IgnoreSsl
-				}
-			}
 		}
 
 		imageOptions := distro.ImageOptions{Size: imageType.Size(0)}
@@ -458,9 +426,9 @@ func (h *apiHandlers) PostCompose(ctx echo.Context) error {
 		irs = append(irs, imageRequest{
 			imageType:               imageType,
 			arch:                    arch,
-			repositories:            repositories,
+			repositories:            repos,
 			imageOptions:            imageOptions,
-			packageSetsRepositories: packageSetsRepositories,
+			packageSetsRepositories: pkgSetsRepos,
 			target:                  irTarget,
 		})
 	}
@@ -1173,3 +1141,54 @@ func (h *apiHandlers) GetComposeManifests(ctx echo.Context, id string) error {
 
 	return ctx.JSON(http.StatusOK, resp)
 }
+
+func collectRepos(irRepos, payloadRepositories []Repository, payloadPackageSets []string) ([]rpmmd.RepoConfig, map[string][]rpmmd.RepoConfig, error) {
+	// build package set repository map and base repository set based on repository package sets
+	// No package_sets -> base set
+	mainRepoConfigs := make([]rpmmd.RepoConfig, 0, len(irRepos))
+	pkgSetsRepoConfigs := make(map[string][]rpmmd.RepoConfig, len(irRepos))
+
+	for _, irRepo := range irRepos {
+		repo, err := genRepoConfig(irRepo)
+		if err != nil {
+			return nil, nil, err
+		}
+		if pkgSets := irRepo.PackageSets; pkgSets != nil && len(*irRepo.PackageSets) > 0 {
+			for _, pkgSet := range *pkgSets {
+				pkgSetsRepoConfigs[pkgSet] = append(pkgSetsRepoConfigs[pkgSet], *repo)
+			}
+		} else {
+			mainRepoConfigs = append(mainRepoConfigs, *repo)
+		}
+	}
+
+	// add user custom repos to all payload package sets
+	for _, plRepo := range payloadRepositories {
+		for _, payloadName := range payloadPackageSets {
+			repo, err := genRepoConfig(plRepo)
+			if err != nil {
+				return nil, nil, err
+			}
+			pkgSetsRepoConfigs[payloadName] = append(pkgSetsRepoConfigs[payloadName], *repo)
+		}
+	}
+
+	return mainRepoConfigs, pkgSetsRepoConfigs, nil
+}
+
+func genRepoConfig(repo Repository) (*rpmmd.RepoConfig, error) {
+	repoConfig := new(rpmmd.RepoConfig)
+	repoConfig.RHSM = repo.Rhsm
+
+	if repo.Baseurl != nil {
+		repoConfig.BaseURL = *repo.Baseurl
+	} else if repo.Mirrorlist != nil {
+		repoConfig.MirrorList = *repo.Mirrorlist
+	} else if repo.Metalink != nil {
+		repoConfig.Metalink = *repo.Metalink
+	} else {
+		return nil, HTTPError(ErrorInvalidRepository)
+	}
+
+	return repoConfig, nil
+}