From 3496efe70d6ca3e871338f4de9a4d0b163869524 Mon Sep 17 00:00:00 2001 From: Diaa Sami Date: Fri, 25 Mar 2022 10:59:09 +0100 Subject: [PATCH] koji: initialize retryable client properly Previously used client has MaxRetries of zero, so was not effectively retrying Fixes COMPOSER-1420 --- internal/upload/koji/koji.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/upload/koji/koji.go b/internal/upload/koji/koji.go index 1980a3cd5..d35b7b07e 100644 --- a/internal/upload/koji/koji.go +++ b/internal/upload/koji/koji.go @@ -331,13 +331,13 @@ func (k *Koji) uploadChunk(chunk []byte, filepath, filename string, offset uint6 return shouldRetry, retErr } - client := rh.Client{ - HTTPClient: &http.Client{ - Transport: k.transport, - }, - CheckRetry: countingCheckRetry, - Logger: rh.LeveledLogger(&LeveledLogrus{logrus.StandardLogger()}), + client := rh.NewClient() + + client.HTTPClient = &http.Client{ + Transport: k.transport, } + client.CheckRetry = countingCheckRetry + client.Logger = rh.LeveledLogger(&LeveledLogrus{logrus.StandardLogger()}) respData, err := client.Post(u.String(), "application/octet-stream", bytes.NewBuffer(chunk))