From 39a65e3f344123dd3e99a6a956ec065dc5c77858 Mon Sep 17 00:00:00 2001
From: Lukas Zapletal <lzap+git@redhat.com>
Date: Tue, 8 Jul 2025 15:38:14 +0200
Subject: [PATCH] client: improve test temporary dirs

---
 internal/client/unit_test.go | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/internal/client/unit_test.go b/internal/client/unit_test.go
index 3628daa68..0b3ef988c 100644
--- a/internal/client/unit_test.go
+++ b/internal/client/unit_test.go
@@ -6,7 +6,6 @@
 package client
 
 import (
-	"io/ioutil"
 	"log"
 	"net"
 	"net/http"
@@ -45,7 +44,7 @@ func setupDNFJSON() string {
 
 func executeTests(m *testing.M) int {
 	// Setup the mocked server running on a temporary domain socket
-	tmpdir, err := ioutil.TempDir("", "client_test-")
+	tmpdir, err := os.MkdirTemp("", "client_test-")
 	if err != nil {
 		panic(err)
 	}
@@ -79,6 +78,11 @@ func executeTests(m *testing.M) int {
 	})
 
 	dspath, err := os.MkdirTemp(tmpdir, "")
+	if err != nil {
+		log.Fatalf("ERROR: Could not create temporary directory for dnfjson: %s\n", err)
+	}
+	defer os.RemoveAll(dspath)
+
 	dnfjsonFixture := dnfjson_mock.Base(dspath)
 	solver := dnfjson.NewBaseSolver(path.Join(tmpdir, "dnfjson-cache"))
 	solver.SetDNFJSONPath(dnfjsonPath, dnfjsonFixture)