From 4bb61da37ef1f2acd46aaa884def02b86de7dbfe Mon Sep 17 00:00:00 2001 From: Sanne Raymaekers Date: Thu, 30 May 2024 15:07:52 +0200 Subject: [PATCH] Revert "prometheus: active worker gauge" This reverts commit 68bc8e0c884830061c0fd7c69be9a02988cf0392. --- internal/prometheus/worker_metrics.go | 23 ----------------------- internal/worker/server.go | 3 --- 2 files changed, 26 deletions(-) delete mode 100644 internal/prometheus/worker_metrics.go diff --git a/internal/prometheus/worker_metrics.go b/internal/prometheus/worker_metrics.go deleted file mode 100644 index 6200d3994..000000000 --- a/internal/prometheus/worker_metrics.go +++ /dev/null @@ -1,23 +0,0 @@ -package prometheus - -import ( - "github.com/prometheus/client_golang/prometheus" - "github.com/prometheus/client_golang/prometheus/promauto" -) - -var ( - ActiveWorkers = promauto.NewGaugeVec(prometheus.GaugeOpts{ - Name: "active_workers", - Namespace: Namespace, - Subsystem: WorkerSubsystem, - Help: "Active workers", - }, []string{"worker", "tenant", "arch"}) -) - -func AddActiveWorker(worker, tenant, arch string) { - ActiveWorkers.WithLabelValues(worker, tenant, arch).Inc() -} - -func RemoveActiveWorker(worker, tenant, arch string) { - ActiveWorkers.WithLabelValues(worker, tenant, arch).Dec() -} diff --git a/internal/worker/server.go b/internal/worker/server.go index cb728d5e6..2782c16d3 100644 --- a/internal/worker/server.go +++ b/internal/worker/server.go @@ -168,9 +168,7 @@ func (s *Server) WatchWorkers() { err = s.jobs.DeleteWorker(w.ID) if err != nil { logrus.Warningf("Unable to remove worker: %v", err) - continue } - prometheus.RemoveActiveWorker(w.ID.String(), w.Channel, w.Arch) } } } @@ -830,7 +828,6 @@ func (s *Server) RegisterWorker(c, a string) (uuid.UUID, error) { if err != nil { return uuid.Nil, err } - prometheus.AddActiveWorker(workerID.String(), c, a) logrus.Infof("Worker (%v) registered", a) return workerID, nil }