diff --git a/internal/distro/fedora/distro.go b/internal/distro/fedora/distro.go index 94f17e97c..122928a0f 100644 --- a/internal/distro/fedora/distro.go +++ b/internal/distro/fedora/distro.go @@ -83,7 +83,7 @@ var ( EnabledServices: iotServices, }, rpmOstree: true, - pipelines: edgeCommitPipelines, + pipelines: iotCommitPipelines, buildPipelines: []string{"build"}, payloadPipelines: []string{"ostree-tree", "ostree-commit", "commit-archive"}, exports: []string{"commit-archive"}, @@ -489,7 +489,7 @@ type imageType struct { // bootISO: installable ISO bootISO bool - // rpmOstree: edge/ostree + // rpmOstree: iot/ostree rpmOstree bool // bootable image bootable bool diff --git a/internal/distro/fedora/distro_test.go b/internal/distro/fedora/distro_test.go index a15f39c70..9bb70b0b7 100644 --- a/internal/distro/fedora/distro_test.go +++ b/internal/distro/fedora/distro_test.go @@ -530,7 +530,7 @@ func TestDistro_CustomFileSystemManifestError(t *testing.T) { _, err := imgType.Manifest(bp.Customizations, distro.ImageOptions{}, nil, nil, 0) if imgTypeName == "fedora-iot-commit" || imgTypeName == "fedora-iot-container" { assert.EqualError(t, err, "Custom mountpoints are not supported for ostree types") - } else if imgTypeName == "fedora-iot-installer" || imgTypeName == "edge-simplified-installer" || imgTypeName == "edge-raw-image" { + } else if imgTypeName == "fedora-iot-installer" { continue } else { assert.EqualError(t, err, "The following custom mountpoints are not supported [\"/boot\"]") diff --git a/internal/distro/fedora/package_sets.go b/internal/distro/fedora/package_sets.go index 84ee17f93..bd2b86bd1 100644 --- a/internal/distro/fedora/package_sets.go +++ b/internal/distro/fedora/package_sets.go @@ -74,7 +74,7 @@ func ec2CommonPackageSet(t *imageType) rpmmd.PackageSet { }.Append(bootPackageSet(t)) } -// common edge image build package set +// common iot image build package set func iotBuildPackageSet(t *imageType) rpmmd.PackageSet { return distroBuildPackageSet(t).Append( rpmmd.PackageSet{ diff --git a/internal/distro/fedora/pipelines.go b/internal/distro/fedora/pipelines.go index 5ddbeac18..0758feeda 100644 --- a/internal/distro/fedora/pipelines.go +++ b/internal/distro/fedora/pipelines.go @@ -24,14 +24,14 @@ func qcow2Pipelines(t *imageType, customizations *blueprint.Customizations, opti return nil, err } - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, partitionTable) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, partitionTable) if err != nil { return nil, err } pipelines = append(pipelines, *treePipeline) diskfile := "disk.img" - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[blueprintPkgsKey], customizations.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[osPkgsKey], customizations.GetKernel().Name) imagePipeline := liveImagePipeline(treePipeline.Name, diskfile, partitionTable, t.arch, kernelVer) pipelines = append(pipelines, *imagePipeline) @@ -61,14 +61,14 @@ func vhdPipelines(t *imageType, customizations *blueprint.Customizations, option return nil, err } - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, partitionTable) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, partitionTable) if err != nil { return nil, err } pipelines = append(pipelines, *treePipeline) diskfile := "disk.img" - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[blueprintPkgsKey], customizations.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[osPkgsKey], customizations.GetKernel().Name) imagePipeline := liveImagePipeline(treePipeline.Name, diskfile, partitionTable, t.arch, kernelVer) pipelines = append(pipelines, *imagePipeline) @@ -86,14 +86,14 @@ func vmdkPipelines(t *imageType, customizations *blueprint.Customizations, optio return nil, err } - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, partitionTable) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, partitionTable) if err != nil { return nil, err } pipelines = append(pipelines, *treePipeline) diskfile := "disk.img" - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[blueprintPkgsKey], customizations.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[osPkgsKey], customizations.GetKernel().Name) imagePipeline := liveImagePipeline(treePipeline.Name, diskfile, partitionTable, t.arch, kernelVer) pipelines = append(pipelines, *imagePipeline) @@ -111,14 +111,14 @@ func openstackPipelines(t *imageType, customizations *blueprint.Customizations, return nil, err } - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, partitionTable) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, partitionTable) if err != nil { return nil, err } pipelines = append(pipelines, *treePipeline) diskfile := "disk.img" - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[blueprintPkgsKey], customizations.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[osPkgsKey], customizations.GetKernel().Name) imagePipeline := liveImagePipeline(treePipeline.Name, diskfile, partitionTable, t.arch, kernelVer) pipelines = append(pipelines, *imagePipeline) @@ -138,13 +138,13 @@ func ec2CommonPipelines(t *imageType, customizations *blueprint.Customizations, return nil, err } - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, partitionTable) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, partitionTable) if err != nil { return nil, err } pipelines = append(pipelines, *treePipeline) - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[blueprintPkgsKey], customizations.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packageSetSpecs[osPkgsKey], customizations.GetKernel().Name) imagePipeline := liveImagePipeline(treePipeline.Name, diskfile, partitionTable, t.arch, kernelVer) pipelines = append(pipelines, *imagePipeline) return pipelines, nil @@ -187,7 +187,7 @@ func iotCorePipelines(t *imageType, customizations *blueprint.Customizations, op pipelines := make([]osbuild.Pipeline, 0) pipelines = append(pipelines, *buildPipeline(repos, packageSetSpecs[buildPkgsKey], t.arch.distro.runner)) - treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], packageSetSpecs[blueprintPkgsKey], customizations, options, nil) + treePipeline, err := osPipeline(t, repos, packageSetSpecs[osPkgsKey], customizations, options, nil) if err != nil { return nil, err } @@ -198,7 +198,7 @@ func iotCorePipelines(t *imageType, customizations *blueprint.Customizations, op return pipelines, nil } -func edgeCommitPipelines(t *imageType, customizations *blueprint.Customizations, options distro.ImageOptions, repos []rpmmd.RepoConfig, packageSetSpecs map[string][]rpmmd.PackageSpec, rng *rand.Rand) ([]osbuild.Pipeline, error) { +func iotCommitPipelines(t *imageType, customizations *blueprint.Customizations, options distro.ImageOptions, repos []rpmmd.RepoConfig, packageSetSpecs map[string][]rpmmd.PackageSpec, rng *rand.Rand) ([]osbuild.Pipeline, error) { pipelines, err := iotCorePipelines(t, customizations, options, repos, packageSetSpecs) if err != nil { return nil, err @@ -237,7 +237,6 @@ func buildPipeline(repos []rpmmd.RepoConfig, buildPackageSpecs []rpmmd.PackageSp func osPipeline(t *imageType, repos []rpmmd.RepoConfig, packages []rpmmd.PackageSpec, - bpPackages []rpmmd.PackageSpec, c *blueprint.Customizations, options distro.ImageOptions, pt *disk.PartitionTable) (*osbuild.Pipeline, error) { @@ -249,7 +248,6 @@ func osPipeline(t *imageType, p.Name = "os" } p.Build = "name:build" - packages = append(packages, bpPackages...) if t.rpmOstree && options.OSTree.Parent != "" && options.OSTree.URL != "" { p.AddStage(osbuild.NewOSTreePasswdStage("org.osbuild.source", options.OSTree.Parent)) @@ -415,7 +413,7 @@ func osPipeline(t *imageType, } p = prependKernelCmdlineStage(p, strings.Join(kernelOptions, " "), pt) p.AddStage(osbuild.NewFSTabStage(osbuild.NewFSTabStageOptions(pt))) - kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(bpPackages, c.GetKernel().Name) + kernelVer := rpmmd.GetVerStrFromPackageSpecListPanic(packages, c.GetKernel().Name) bootloader := bootloaderConfigStage(t, *pt, kernelVer, false, false) if cfg := imageConfig.Grub2Config; cfg != nil {