particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

koji: increment retry counter only when retrying

Browse source
This commit is contained in:
Diaa Sami 2022-03-25 11:09:33 +01:00 • committed by Ondřej Budai
parent 6b08b8ed63
commit 68639b4bf9
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/upload/koji/koji.go
View file

@ -314,7 +314,6 @@ func (k *Koji) uploadChunk(chunk []byte, filepath, filename string, offset uint6
retries := uint(0)
countingCheckRetry := func(ctx context.Context, resp *http.Response, err error) (bool, error) {
retries++
shouldRetry, retErr := rh.DefaultRetryPolicy(ctx, resp, err)
// DefaultRetryPolicy denies retrying for any certificate related error.
@ -323,11 +322,16 @@ func (k *Koji) uploadChunk(chunk []byte, filepath, filename string, offset uint6
if v, ok := err.(*url.Error); ok {
if _, ok := v.Err.(x509.UnknownAuthorityError); ok {
// retry if it's a timeout
return strings.Contains(strings.ToLower(v.Error()), "timeout"), v
shouldRetry = strings.Contains(strings.ToLower(v.Error()), "timeout")
retErr = v
}
}
}
if shouldRetry {
retries++
}
return shouldRetry, retErr
}