particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

jobsite/builder: check deferred close.

Browse source 
Check the deffered close by providing a name return value.
This commit is contained in:
Simon de Vlieger 2024-02-09 10:07:23 +01:00 • committed by Sanne Raymaekers
parent c7788798c6
commit 7548870e91
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cmd/osbuild-jobsite-builder/main.go
View file

@ -153,7 +153,7 @@ func (agent *Agent) HandleClaim(w http.ResponseWriter, r *http.Request) error {
return nil
}
func (agent *Agent) HandleProvision(w http.ResponseWriter, r *http.Request) error {
func (agent *Agent) HandleProvision(w http.ResponseWriter, r *http.Request) (err error) {
agent.GuardState(StateProvision)
if r.Method != "PUT" {
@ -167,7 +167,12 @@ func (agent *Agent) HandleProvision(w http.ResponseWriter, r *http.Request) erro
os.O_WRONLY|os.O_CREATE|os.O_EXCL,
0400,
)
defer dst.Close()
defer func() {
if cerr := dst.Close(); cerr != nil {
err = cerr
}
}()
if err != nil {
return fmt.Errorf("Agent.HandleProvision: Failed to open manifest.json.")