particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

store: Fix test for CheckGPG

Browse source 
Forgot the #1 rule of map iteration. Don't depend on the order.
This uses a slice instead, which should be just as good for testing the
loop variable alias behavior.
This commit is contained in:
Brian C. Lane 2023-11-01 11:27:31 -07:00 • committed by Achilleas Koutsou
parent a693928b7a
commit 8e933f84f9
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
internal/store/store_test.go
View file

@ -492,16 +492,16 @@ func (suite *storeTest) TestRepoConfigMirrorlist() {
// Test multiple SourceConfigs with different CheckGPG and CheckRepoGPG settings
func (suite *storeTest) TestSourceConfigGPGKeysTrueFalse() {
// We only care about the GPG bools
sources := map[string]SourceConfig{
"source-with-true": {Name: "source-with-true", CheckGPG: true, CheckRepoGPG: true},
"source-with-false": {Name: "source-with-false", CheckGPG: false, CheckRepoGPG: false},
sources := []SourceConfig{
{Name: "source-with-true", CheckGPG: true, CheckRepoGPG: true},
{Name: "source-with-false", CheckGPG: false, CheckRepoGPG: false},
}
// source is reused inside the loop, which can result in unexpected changes in go < 1.22
// https://go.dev/blog/loopvar-preview
var repos []rpmmd.RepoConfig
for id, source := range sources {
repos = append(repos, source.RepoConfig(id))
for _, source := range sources {
repos = append(repos, source.RepoConfig(source.Name))
}
// First repo should be true, second should be false
@ -512,14 +512,14 @@ func (suite *storeTest) TestSourceConfigGPGKeysTrueFalse() {
// We only care about the GPG bools
// Test with false then true
sources = map[string]SourceConfig{
"source-with-false": {Name: "source-with-false", CheckGPG: false, CheckRepoGPG: false},
"source-with-true": {Name: "source-with-true", CheckGPG: true, CheckRepoGPG: true},
sources = []SourceConfig{
{Name: "source-with-false", CheckGPG: false, CheckRepoGPG: false},
{Name: "source-with-true", CheckGPG: true, CheckRepoGPG: true},
}
repos = []rpmmd.RepoConfig{}
for id, source := range sources {
repos = append(repos, source.RepoConfig(id))
for _, source := range sources {
repos = append(repos, source.RepoConfig(source.Name))
}
// First repo should be false, second should be true