particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

osbuild-service-maintenance: Delete/update results in chunks

Browse source 
The results of the manifest jobs can be very big, and operating on
30-40k rows at once can starve or crash a smaller rds instance.
This commit is contained in:
Sanne Raymaekers 2022-06-06 14:17:46 +02:00
parent daaab1742e
commit 92ae2f7c83
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

19
cmd/osbuild-service-maintenance/db.go
View file

@ -28,12 +28,21 @@ func DBCleanup(dbURL string, dryRun bool, cutoff time.Time) error {
logrus.Info("Dry run, skipping deletion of jobs")
continue
}
rows, err := jobs.DeleteJobResult(v)
if err != nil {
logrus.Errorf("Error deleting results for jobs: %v, %d rows affected", rows, err)
continue
// Delete results in chunks to avoid starving the rds instance
for i := 0; i < len(v); i += 100 {
max := i + 100
if max > len(v) {
max = len(v)
}
rows, err := jobs.DeleteJobResult(v[i:max])
if err != nil {
logrus.Errorf("Error deleting results for jobs: %v, %d rows affected", rows, err)
continue
}
logrus.Infof("Deleted results from %d jobs out of %d job ids", rows, len(v))
}
logrus.Infof("Deleted results from %d jobs out of %d job ids", rows, len(v))
}
return nil