From a58a399008f0abb22e5b7bfac78ccaabe9f12f55 Mon Sep 17 00:00:00 2001 From: Lukas Zapletal Date: Mon, 4 Aug 2025 14:36:22 +0200 Subject: [PATCH] v2: update errors test for new error type The oapi-codegen update to v2.5.0 changed the Details field of the main Error type to be an empty interface. This requires updates to the error handling tests to accommodate the new structure. --- internal/cloudapi/v2/errors_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/cloudapi/v2/errors_test.go b/internal/cloudapi/v2/errors_test.go index e5898adfa..6d53463e9 100644 --- a/internal/cloudapi/v2/errors_test.go +++ b/internal/cloudapi/v2/errors_test.go @@ -114,7 +114,7 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorEnqueueingJob).reason, apiErr.Reason) - require.Empty(t, *apiErr.Details) + require.Empty(t, apiErr.Details) } // HTTPErrorWithInternal @@ -131,7 +131,7 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorEnqueueingJob).reason, apiErr.Reason) - require.Equal(t, err.Error(), *apiErr.Details) + require.Equal(t, err.Error(), apiErr.Details) } // HTTPErrorWithDetails @@ -149,7 +149,7 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorEnqueueingJob).reason, apiErr.Reason) - require.Equal(t, "even more extra details", *apiErr.Details) + require.Equal(t, "even more extra details", apiErr.Details) } // echo.HTTPError @@ -166,7 +166,7 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorUnspecified).reason, apiErr.Reason) - require.Equal(t, "code=500, message=some unexpected internal http error", *apiErr.Details) + require.Equal(t, "code=500, message=some unexpected internal http error", apiErr.Details) } // echo.HTTPError and internalErr is nil @@ -182,7 +182,7 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorUnspecified).reason, apiErr.Reason) - require.Equal(t, "code=500, message=", *apiErr.Details) + require.Equal(t, "code=500, message=", apiErr.Details) } // plain error @@ -199,6 +199,6 @@ func TestHTTPErrorHandler(t *testing.T) { require.NotNil(t, apiErr) require.Equal(t, "opid", apiErr.OperationId) require.Equal(t, find(ErrorNotHTTPError).reason, apiErr.Reason) - require.Equal(t, "some unexpected internal error", *apiErr.Details) + require.Equal(t, "some unexpected internal error", apiErr.Details) } }