From a7119a4d0f2115f224b70d92457406dbdfba06da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20Sch=C3=BCller?= <florian.schueller@redhat.com>
Date: Tue, 3 Dec 2024 12:13:45 +0100
Subject: [PATCH] osbuild-service-maintenance/aws: support aws credential file

Support running the maintenance locally with a valid
`~/aws/credentials` file. HMS-3632
---
 Makefile                               | 18 +++++++++++++++---
 cmd/osbuild-service-maintenance/aws.go | 18 +++++++++++++++---
 2 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 9103c6c16..e5421316d 100644
--- a/Makefile
+++ b/Makefile
@@ -130,8 +130,13 @@ man: $(MANPAGES_TROFF)
 # They are not supported nor is their use recommended in scripts.
 #
 
+.PHONY: build-maintenance
+build-maintenance: $(BUILDDIR)/bin/
+	go build -o $<osbuild-service-maintenance ./cmd/osbuild-service-maintenance
+	go test -c -tags=integration -o $<osbuild-composer-maintenance-tests ./cmd/osbuild-service-maintenance/
+
 .PHONY: build
-build: $(BUILDDIR)/bin/
+build: $(BUILDDIR)/bin/ build-maintenance
 	go build -o $<osbuild-composer ./cmd/osbuild-composer/
 	go build -o $<osbuild-worker ./cmd/osbuild-worker/
 	go build -o $<osbuild-worker-executor ./cmd/osbuild-worker-executor/
@@ -141,7 +146,6 @@ build: $(BUILDDIR)/bin/
 	go build -o $<osbuild-upload-oci ./cmd/osbuild-upload-oci/
 	go build -o $<osbuild-upload-generic-s3 ./cmd/osbuild-upload-generic-s3/
 	go build -o $<osbuild-mock-openid-provider ./cmd/osbuild-mock-openid-provider
-	go build -o $<osbuild-service-maintenance ./cmd/osbuild-service-maintenance
 	go build -o $<osbuild-jobsite-manager ./cmd/osbuild-jobsite-manager
 	go build -o $<osbuild-jobsite-builder ./cmd/osbuild-jobsite-builder
 	# also build the test binaries
@@ -152,7 +156,6 @@ build: $(BUILDDIR)/bin/
 	go test -c -tags=integration -o $<osbuild-auth-tests ./cmd/osbuild-auth-tests/
 	go test -c -tags=integration -o $<osbuild-koji-tests ./cmd/osbuild-koji-tests/
 	go test -c -tags=integration -o $<osbuild-composer-dbjobqueue-tests ./cmd/osbuild-composer-dbjobqueue-tests/
-	go test -c -tags=integration -o $<osbuild-composer-maintenance-tests ./cmd/osbuild-service-maintenance/
 
 .PHONY: install
 install: build
@@ -373,3 +376,12 @@ $(PROCESSED_TEMPLATE_DIR)/%.yml: $(PROCESSED_TEMPLATE_DIR) $(OPENSHIFT_TEMPLATES
 .PHONY: process-templates
 process-templates: $(addprefix $(PROCESSED_TEMPLATE_DIR)/, $(OPENSHIFT_TEMPLATES))
 
+# get yourself aws access to your deployment by
+# either setting AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY
+# or providing a token in ~/.aws/credentials
+# for profile "default"!
+.PHONY: osbuild-service-maintenance-dry-run-aws
+osbuild-service-maintenance-dry-run-aws: build-maintenance
+	env DRY_RUN=true \
+	    ENABLE_AWS_MAINTENANCE=true \
+	    $(BUILDDIR)/bin/osbuild-service-maintenance
diff --git a/cmd/osbuild-service-maintenance/aws.go b/cmd/osbuild-service-maintenance/aws.go
index 29c8402da..2229d19e7 100644
--- a/cmd/osbuild-service-maintenance/aws.go
+++ b/cmd/osbuild-service-maintenance/aws.go
@@ -14,9 +14,21 @@ import (
 )
 
 func AWSCleanup(maxConcurrentRequests int, dryRun bool, accessKeyID, accessKey string, cutoff time.Time) error {
-	a, err := awscloud.New("us-east-1", accessKeyID, accessKey, "")
-	if err != nil {
-		return err
+	const region = "us-east-1"
+	var a *awscloud.AWS
+	var err error
+
+	if accessKeyID != "" && accessKey != "" {
+		a, err = awscloud.New(region, accessKeyID, accessKey, "")
+		if err != nil {
+			return err
+		}
+	} else {
+		logrus.Infof("One of AWS_ACCESS_KEY_ID or AWS_SECRET_ACCESS_KEY is missing, trying default credentials…")
+		a, err = awscloud.NewDefault(region)
+		if err != nil {
+			return err
+		}
 	}
 
 	regions, err := a.Regions()