particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: swap the places of expected-actual results in asserts

Browse source 
This results in better output. Output before this swap can be
seen at https://github.com/osbuild/osbuild-composer/issues/611.
It looks like we wanted a compose to FAIL and it FINISHED instead
which is making the error log confusing.
This commit is contained in:
Alexander Todorov 2020-05-14 13:53:49 +03:00 • committed by Alexander Todorov
parent efed778006
commit b9c5942976
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cmd/osbuild-tests/main_test.go
View file

@ -101,7 +101,7 @@ func testCompose(t *testing.T, outputType string) {
uuid := startCompose(t, "empty", outputType) uuid := startCompose(t, "empty", outputType)
defer deleteCompose(t, uuid) defer deleteCompose(t, uuid)
status := waitForCompose(t, uuid) status := waitForCompose(t, uuid)
require.Equalf(t, status, "FINISHED", "Unexpected compose result: %s", status) require.Equalf(t, "FINISHED", status, "Unexpected compose result: %s", status)
runComposerCLI(t, false, "compose", "image", uuid.String()) runComposerCLI(t, false, "compose", "image", uuid.String())
} }
@ -132,7 +132,7 @@ func deleteCompose(t *testing.T, id uuid.UUID) {
err := json.Unmarshal(rawReply, &reply) err := json.Unmarshal(rawReply, &reply)
require.Nilf(t, err, "Unexpected reply: %v", err) require.Nilf(t, err, "Unexpected reply: %v", err)
require.Zerof(t, len(reply.Errors), "Unexpected errors") require.Zerof(t, len(reply.Errors), "Unexpected errors")
require.Equalf(t, len(reply.IDs), 1, "Unexpected number of UUIDs returned: %d", len(reply.IDs)) require.Equalf(t, 1, len(reply.IDs), "Unexpected number of UUIDs returned: %d", len(reply.IDs))
require.Truef(t, reply.IDs[0].Status, "Unexpected status %v", reply.IDs[0].Status) require.Truef(t, reply.IDs[0].Status, "Unexpected status %v", reply.IDs[0].Status)
} }