Test/api.sh: pass TEST_MODULE_HOTFIXES as an env variable

While I was the one to push for TEST_MODULE_HOTFIXES to be passed as an
argument to `api.sh`, when it was implemented, this is turning our to be
impractical. I would like to extend `api.sh` to test distro names with
and without the dot to separate major and minor version and also to test
the ability to specify distro name explicitly (e.g. a distro alias).
Passing all of these new options and their combinations would make the
CLI go wild.

Signed-off-by: Tomáš Hozza <thozza@redhat.com>

.gitlab-ci.yml

@@ -551,7 +551,7 @@ API-module-hotfixes:
     # don't run this test case for nightly trees
   script:
     - schutzbot/deploy.sh
-    - /usr/libexec/tests/osbuild-composer/api.sh "${IMAGE_TYPE}" "" "${TEST_MODULE_HOTFIXES}"
+    - /usr/libexec/tests/osbuild-composer/api.sh "${IMAGE_TYPE}"
   parallel:
     matrix:
       - IMAGE_TYPE:

test/cases/api.sh

@@ -33,8 +33,8 @@ export IMAGE_TYPE_OCI="oci"
 export IMAGE_TYPE_VSPHERE="vsphere"
 export IMAGE_TYPE_IOT_COMMIT="iot-commit"
 
-if (( $# > 3 )); then
+if (( $# > 2 )); then
-    echo "$0 does not support more than three arguments"
+    echo "$0 does not support more than two arguments"
     exit 1
 fi
 
@@ -46,7 +46,9 @@ fi
 set -euo pipefail
 
 IMAGE_TYPE="$1"
-TEST_MODULE_HOTFIXES="${3:-0}"
+
+# set TEST_MODULE_HOTFIXES to 1 to enable module hotfixes for the test
+TEST_MODULE_HOTFIXES="${TEST_MODULE_HOTFIXES:-0}"
 
 # select cloud provider based on image type
 #