particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

distro: Fix bug found by linting

Browse source 
Using new() to create a new struct assigns an empty struct to the
variable, meaning it can never be tested for nil. This means this code
would never detect a missing kernel package.
This commit is contained in:
Brian C. Lane 2022-09-09 10:54:07 -07:00 • committed by Brian C. Lane
parent 826e9d8cc6
commit cf18e2990a
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/distro/rhel8/pipelines.go
View file

@ -238,7 +238,7 @@ func imageInstallerPipelines(t *imageType, customizations *blueprint.Customizati
}
pipelines = append(pipelines, *treePipeline)
kernelPkg := new(rpmmd.PackageSpec)
var kernelPkg *rpmmd.PackageSpec
installerPackages := packageSetSpecs[installerPkgsKey]
for _, pkg := range installerPackages {
if pkg.Name == "kernel" {

2
internal/distro/rhel9/pipelines.go
View file

@ -233,7 +233,7 @@ func imageInstallerPipelines(t *imageType, customizations *blueprint.Customizati
}
pipelines = append(pipelines, *treePipeline)
kernelPkg := new(rpmmd.PackageSpec)
var kernelPkg *rpmmd.PackageSpec
installerPackages := packageSetSpecs[installerPkgsKey]
for _, pkg := range installerPackages {
if pkg.Name == "kernel" {