From d7bff4bd3b556c33d10c74ca268f62df915525fd Mon Sep 17 00:00:00 2001
From: Lars Karlitski <lars@karlitski.net>
Date: Tue, 13 Oct 2020 16:16:22 +0200
Subject: [PATCH] kojiapi: add simple test for the /status API

Add a simple unit test for the koji API.

This adds a Handler() method to the koji.Server struct, which made
writing the test easier. This is a direction we want to go in anyway in
the future.
---
 internal/kojiapi/server.go      |  4 +++
 internal/kojiapi/server_test.go | 53 +++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 internal/kojiapi/server_test.go

diff --git a/internal/kojiapi/server.go b/internal/kojiapi/server.go
index b105595ae..9c7a549d7 100644
--- a/internal/kojiapi/server.go
+++ b/internal/kojiapi/server.go
@@ -64,6 +64,10 @@ func (s *Server) Serve(listener net.Listener) error {
 	return nil
 }
 
+func (s *Server) Handler() http.Handler {
+	return s.server.Handler
+}
+
 // apiHandlers implements api.ServerInterface - the http api route handlers
 // generated from api/openapi.yml. This is a separate object, because these
 // handlers should not be exposed on the `Server` object.
diff --git a/internal/kojiapi/server_test.go b/internal/kojiapi/server_test.go
new file mode 100644
index 000000000..78c4096c7
--- /dev/null
+++ b/internal/kojiapi/server_test.go
@@ -0,0 +1,53 @@
+package kojiapi_test
+
+import (
+	"encoding/json"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/osbuild/osbuild-composer/internal/jobqueue/testjobqueue"
+	"github.com/osbuild/osbuild-composer/internal/kojiapi"
+	"github.com/osbuild/osbuild-composer/internal/kojiapi/api"
+	distro_mock "github.com/osbuild/osbuild-composer/internal/mocks/distro"
+	rpmmd_mock "github.com/osbuild/osbuild-composer/internal/mocks/rpmmd"
+	"github.com/osbuild/osbuild-composer/internal/upload/koji"
+	"github.com/osbuild/osbuild-composer/internal/worker"
+	"github.com/stretchr/testify/require"
+)
+
+func newTestKojiServer(t *testing.T) *kojiapi.Server {
+	rpm_fixture := rpmmd_mock.BaseFixture()
+	rpm := rpmmd_mock.NewRPMMDMock(rpm_fixture)
+	require.NotNil(t, rpm)
+
+	distros, err := distro_mock.NewDefaultRegistry()
+	require.NoError(t, err)
+	require.NotNil(t, distros)
+
+	workers := worker.NewServer(nil, testjobqueue.New(), "")
+	require.NotNil(t, workers)
+
+	server := kojiapi.NewServer(nil, workers, rpm, distros, map[string]koji.GSSAPICredentials{})
+	require.NotNil(t, server)
+
+	return server
+}
+
+func TestStatus(t *testing.T) {
+	server := newTestKojiServer(t)
+	handler := server.Handler()
+
+	req := httptest.NewRequest("GET", "/api/composer-koji/v1/status", nil)
+	req.Header.Set("Content-Type", "application/json")
+
+	rec := httptest.NewRecorder()
+	handler.ServeHTTP(rec, req)
+	resp := rec.Result()
+
+	require.Equal(t, 200, resp.StatusCode)
+
+	var status api.Status
+	err := json.NewDecoder(resp.Body).Decode(&status)
+	require.NoError(t, err)
+	require.Equal(t, "OK", status.Status)
+}