diff --git a/cmd/osbuild-composer/main.go b/cmd/osbuild-composer/main.go index 18111fe96..3266d8a2a 100644 --- a/cmd/osbuild-composer/main.go +++ b/cmd/osbuild-composer/main.go @@ -90,7 +90,7 @@ func main() { func writeFileAtomically(filename string, data []byte, mode os.FileMode) error { dir, name := filepath.Dir(filename), filepath.Base(filename) - tmpfile, err := ioutil.TempFile(dir, name + "-*.tmp") + tmpfile, err := ioutil.TempFile(dir, name+"-*.tmp") if err != nil { return err } diff --git a/init/osbuild-composer-worker@.service b/init/osbuild-composer-worker@.service new file mode 100644 index 000000000..f63f5b63e --- /dev/null +++ b/init/osbuild-composer-worker@.service @@ -0,0 +1,10 @@ +[Unit] +Description=OSBuild Composer Worker (%i) + +[Service] +PrivateTmp=true +ExecStart=/usr/local/lib/osbuild-composer/osbuild-composer-worker -C /var/lib/osbuild + +[Install] +DefaultInstance=1 +WantedBy=default.target diff --git a/internal/weldr/api.go b/internal/weldr/api.go index b8a1db5a9..472c38ffb 100644 --- a/internal/weldr/api.go +++ b/internal/weldr/api.go @@ -405,8 +405,8 @@ func (api *API) blueprintsInfoHandler(writer http.ResponseWriter, request *http. json.NewEncoder(writer).Encode(reply{ Blueprints: blueprints, - Changes: changes, - Errors: []string{}, + Changes: changes, + Errors: []string{}, }) } @@ -449,7 +449,7 @@ func (api *API) blueprintsDepsolveHandler(writer http.ResponseWriter, request *h json.NewEncoder(writer).Encode(reply{ Blueprints: blueprints, - Errors: []string{}, + Errors: []string{}, }) } diff --git a/internal/weldr/api_test.go b/internal/weldr/api_test.go index 76517786e..f615c088c 100644 --- a/internal/weldr/api_test.go +++ b/internal/weldr/api_test.go @@ -20,9 +20,9 @@ var repo = rpmmd.RepoConfig{ BaseURL: "http://example.com/test/os", } -var packages = rpmmd.PackageList { - { Name: "package1" }, - { Name: "package2" }, +var packages = rpmmd.PackageList{ + {Name: "package1"}, + {Name: "package2"}, } func testRoute(t *testing.T, api *weldr.API, method, path, body string, expectedStatus int, expectedJSON string) { @@ -110,7 +110,7 @@ func TestBasic(t *testing.T) { {"/api/v0/blueprints/info/example", http.StatusOK, `*`}, } - for _, c:= range cases { + for _, c := range cases { api := weldr.New(repo, packages, nil) testRoute(t, api, "GET", c.Path, ``, c.ExpectedStatus, c.ExpectedJSON) } @@ -124,7 +124,7 @@ func TestBlueprints(t *testing.T) { http.StatusOK, `{"status":true}`) testRoute(t, api, "GET", "/api/v0/blueprints/info/test", ``, - http.StatusOK, `{"blueprints":[{"name":"test","description":"Test","modules":[],"packages":[{"name":"httpd","version":"2.4.*"}],"version":"0"}], + http.StatusOK, `{"blueprints":[{"name":"test","description":"Test","modules":[],"packages":[{"name":"httpd","version":"2.4.*"}],"version":"0"}], "changes":[{"name":"test","changed":false}], "errors":[]}`) testRoute(t, api, "POST", "/api/v0/blueprints/workspace", @@ -132,6 +132,6 @@ func TestBlueprints(t *testing.T) { http.StatusOK, `{"status":true}`) testRoute(t, api, "GET", "/api/v0/blueprints/info/test", ``, - http.StatusOK, `{"blueprints":[{"name":"test","description":"Test","modules":[],"packages":[{"name":"systemd","version":"123"}],"version":"0"}], + http.StatusOK, `{"blueprints":[{"name":"test","description":"Test","modules":[],"packages":[{"name":"systemd","version":"123"}],"version":"0"}], "changes":[{"name":"test","changed":true}], "errors":[]}`) } diff --git a/internal/weldr/store.go b/internal/weldr/store.go index 453ba9b5d..9774d98f0 100644 --- a/internal/weldr/store.go +++ b/internal/weldr/store.go @@ -1,8 +1,8 @@ package weldr import ( - "log" "encoding/json" + "log" "sort" "sync" )