From e10a7f1cccdb2d00fa8bb95add311ce395cae411 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Budai?= Date: Mon, 30 Nov 2020 09:20:51 +0100 Subject: [PATCH] {koji,worker}/server: log errors returned from handlers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, we had no clue what errors were catched by the default echo's error handler. Thus, in the case of an error, we were basically blind. Let's log all errors so we can investigate them later. Signed-off-by: Ondřej Budai --- internal/kojiapi/server.go | 6 ++++++ internal/worker/server.go | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/internal/kojiapi/server.go b/internal/kojiapi/server.go index 76b6eb336..ef330fb48 100644 --- a/internal/kojiapi/server.go +++ b/internal/kojiapi/server.go @@ -46,6 +46,12 @@ func (s *Server) Handler(path string) http.Handler { e.Binder = binder{} e.StdLogger = s.logger + // log errors returned from handlers + e.HTTPErrorHandler = func(err error, c echo.Context) { + log.Println(c.Path(), c.QueryParams().Encode(), err.Error()) + e.DefaultHTTPErrorHandler(err, c) + } + api.RegisterHandlers(e.Group(path), &apiHandlers{s}) return e diff --git a/internal/worker/server.go b/internal/worker/server.go index c81ac18bc..665d06c1a 100644 --- a/internal/worker/server.go +++ b/internal/worker/server.go @@ -62,6 +62,12 @@ func (s *Server) Handler() http.Handler { e.Binder = binder{} e.StdLogger = s.logger + // log errors returned from handlers + e.HTTPErrorHandler = func(err error, c echo.Context) { + log.Println(c.Path(), c.QueryParams().Encode(), err.Error()) + e.DefaultHTTPErrorHandler(err, c) + } + handler := apiHandlers{ server: s, }