From e165db63eadbeaff65cf231a7e8774de3bf98d3e Mon Sep 17 00:00:00 2001 From: Gianluca Zuccarelli Date: Wed, 15 Dec 2021 12:25:48 +0000 Subject: [PATCH] metrics: add additional buckets The change between the 32s bucket and the 64s bucket is too drastic for measuring the duration of depsolve jobs. At present, 90% of the depsolve jobs have a duration inbetween 32s and 64s, making the 32s bucket too sensitive and the 64s bucket not sensitive enough. --- internal/prometheus/job_metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/prometheus/job_metrics.go b/internal/prometheus/job_metrics.go index 3f87f7072..9c6e17b5e 100644 --- a/internal/prometheus/job_metrics.go +++ b/internal/prometheus/job_metrics.go @@ -31,7 +31,7 @@ var ( Namespace: namespace, Subsystem: workerSubsystem, Help: "Duration spent by workers on a job.", - Buckets: []float64{.1, .2, .5, 1, 2, 4, 8, 16, 32, 64, 96, 128, 160, 192, 224, 256, 320, 382, 448, 512, 640, 768, 896, 1024, 1280, 1536, 1792, 2049}, + Buckets: []float64{.1, .2, .5, 1, 2, 4, 8, 16, 32, 40, 48, 64, 96, 128, 160, 192, 224, 256, 320, 382, 448, 512, 640, 768, 896, 1024, 1280, 1536, 1792, 2049}, }, []string{"type"}) ) @@ -41,6 +41,6 @@ var ( Namespace: namespace, Subsystem: workerSubsystem, Help: "Duration a job spends on the queue.", - Buckets: []float64{.1, .2, .5, 1, 2, 4, 8, 16, 32, 64, 96, 128, 160, 192, 224, 256, 320, 382, 448, 512, 640, 768, 896, 1024, 1280, 1536, 1792, 2049}, + Buckets: []float64{.1, .2, .5, 1, 2, 4, 8, 16, 32, 40, 48, 64, 96, 128, 160, 192, 224, 256, 320, 382, 448, 512, 640, 768, 896, 1024, 1280, 1536, 1792, 2049}, }, []string{"type"}) )