disk: honour the fact that some containers have metadata

Re-introduce the VolumeContainer interface but with a different
meaning: it is supposed to be implemented by all container that
contain volumes and as a result have themselves a size, like eg
LVM2, LUKS2 and PartitionTable (the latter is not yet included).
The sole method on the interface for now is MetadataSize, which
should return the metadata for the container itself.
Use that new `VolumeContainer.MetadataSize` method when we up-
date the sizes of elements in `resizeEntitybranch`.

internal/disk/disk.go

@@ -112,6 +112,15 @@ type UniqueEntity interface {
 	GenUUID(rng *rand.Rand)
 }
 
+// VolumeContainer is a specific container that contains volume entities
+type VolumeContainer interface {
+
+	// MetadataSize returns the size of the container's metadata (in
+	// bytes), i.e. the storage space that needs to be reserved for
+	// the container itself, in contrast to the data it contains.
+	MetadataSize() uint64
+}
+
 // FSSpec for a filesystem (UUID and Label); the first field of fstab(5)
 type FSSpec struct {
 	UUID  string

internal/disk/luks.go

@@ -74,3 +74,12 @@ func (lc *LUKSContainer) GenUUID(rng *rand.Rand) {
 		lc.UUID = uuid.Must(newRandomUUIDFromReader(rng)).String()
 	}
 }
+
+func (lc *LUKSContainer) MetadataSize() uint64 {
+	if lc == nil {
+		return 0
+	}
+
+	// 16 MiB is the default size for the LUKS2 header
+	return 16 * 1024 * 1024
+}

internal/disk/lvm.go

@@ -105,6 +105,18 @@ func (vg *LVMVolumeGroup) CreateMountpoint(mountpoint string, size uint64) (Enti
 	return &vg.LogicalVolumes[len(vg.LogicalVolumes)-1], nil
 }
 
+func (vg *LVMVolumeGroup) MetadataSize() uint64 {
+	if vg == nil {
+		return 0
+	}
+
+	// LVM2 allows for a lot of customizations that will affect the size
+	// of the metadata and its location and thus the start of the physical
+	// extent. For now we assume the default which results in a start of
+	// the physical extent 1 MiB
+	return 1024 * 1024
+}
+
 type LVMLogicalVolume struct {
 	Name    string
 	Size    uint64

internal/disk/partition_table.go

@@ -433,6 +433,9 @@ func resizeEntityBranch(path []Entity, size uint64) {
 				break
 			}
 		}
+		if vc, ok := element.(VolumeContainer); ok {
+			containerSize += vc.MetadataSize()
+		}
 		if containerSize > size {
 			size = containerSize
 		}