From efb100fbca31d416fe28f47a0c8e56413dd38ba8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Budai?= Date: Fri, 28 Feb 2020 15:28:00 +0100 Subject: [PATCH] lint: fix gosimple/S1005 errors --- internal/common/types.go | 4 ++-- internal/weldr/api.go | 2 +- internal/weldr/api_test.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/common/types.go b/internal/common/types.go index 566e6672e..b517e9b36 100644 --- a/internal/common/types.go +++ b/internal/common/types.go @@ -57,7 +57,7 @@ func marshalHelper(input int, mapping map[string]int, errorMessage string) ([]by // See unmarshalHelper for introduction. This helper can create a list of possible values of a single type. func listHelper(mapping map[string]int) []string { ret := make([]string, 0) - for k, _ := range mapping { + for k := range mapping { ret = append(ret, k) } return ret @@ -65,7 +65,7 @@ func listHelper(mapping map[string]int) []string { // See unmarshalHelper for introduction. With this helper one can make sure a value exists in a set of existing values. func existsHelper(mapping map[string]int, testedValue string) bool { - for k, _ := range mapping { + for k := range mapping { if k == testedValue { return true } diff --git a/internal/weldr/api.go b/internal/weldr/api.go index 40e461e9f..c0728a12a 100644 --- a/internal/weldr/api.go +++ b/internal/weldr/api.go @@ -614,7 +614,7 @@ func (api *API) modulesInfoHandler(writer http.ResponseWriter, request *http.Req packageInfos := foundPackages.ToPackageInfos() if modulesRequested { - for i, _ := range packageInfos { + for i := range packageInfos { err := packageInfos[i].FillDependencies(api.rpmmd, api.distro.Repositories(api.arch), api.distro.ModulePlatformID()) if err != nil { errors := responseError{ diff --git a/internal/weldr/api_test.go b/internal/weldr/api_test.go index b82a0d074..e299a5f2d 100644 --- a/internal/weldr/api_test.go +++ b/internal/weldr/api_test.go @@ -484,7 +484,7 @@ func TestComposeDelete(t *testing.T) { idsInStore := []string{} - for id, _ := range s.Composes { + for id := range s.Composes { idsInStore = append(idsInStore, id.String()) }