particle-os/debian-forge-composer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

blueprint: improve error message on missing name

Browse source 
the error should not infer that a version is mandatory.
Also the error message is now explicitly checked
This commit is contained in:
Florian Schüller 2024-02-20 14:27:31 +01:00 • committed by Ondřej Budai
parent e31ec13c87
commit fb8634a991
2 changed files with 16 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

25
internal/client/blueprints_test.go
View file

@ -1238,47 +1238,52 @@ func TestEmptyPackageNameBlueprintJsonV0(t *testing.T) {
"packages": [{"name": "", "version": "1.32.1"}]
}`
// Push a blueprint
expectedErrorPrefix := "BlueprintsError: All package entries need to contain the name of the package."
resp, err := PostJSONBlueprintV0(testState.socket, bp)
require.NoError(t, err, "failed with a client error")
require.False(t, resp.Status, "Negative status expected.")
require.Equal(t, len(resp.Errors), 1, "There should be exactly one error")
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), "BlueprintsError"), "I expect a BlueprintsError")
reasoning := "I expected an error message starting with\n" + expectedErrorPrefix +
"\nnot\n" + resp.Errors[0].String()
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), expectedErrorPrefix), reasoning)
}
func TestEmptyPackageNameBlueprintV0(t *testing.T) {
bp := `name = "EMPTY-PACKAGE-NAME"
description = "empty package name"
version = "0.0.1"
modules = []
groups = []
distro = "test-distro"
[[packages]]
version = "*"
`
expectedErrorPrefix := "BlueprintsError: All package entries need to contain the name of the package."
resp, err := PostTOMLBlueprintV0(testState.socket, bp)
require.NoError(t, err, "failed with a client error")
require.False(t, resp.Status, "Negative status expected.")
require.Equal(t, len(resp.Errors), 1, "There should be exactly one error")
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), "BlueprintsError"), "I expect a BlueprintsError")
reasoning := "I expected an error message starting with\n" + expectedErrorPrefix +
"\nnot\n" + resp.Errors[0].String()
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), expectedErrorPrefix), reasoning)
}
func TestEmptyPackageNameAndVersionBlueprintV0(t *testing.T) {
bp := `name = "EMPTY-PACKAGE-NAME"
description = "empty package name"
version = "0.0.1"
modules = []
groups = []
distro = "test-distro"
[[packages]]
`
expectedErrorPrefix := "BlueprintsError: All package entries need to contain the name of the package."
resp, err := PostTOMLBlueprintV0(testState.socket, bp)
require.NoError(t, err, "failed with a client error")
require.False(t, resp.Status, "Negative status expected.")
require.Equal(t, len(resp.Errors), 1, "There should be exactly one error")
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), "BlueprintsError"), "I expect a BlueprintsError")
reasoning := "I expected an error message starting with\n" + expectedErrorPrefix +
"\nnot\n" + resp.Errors[0].String()
assert.True(t, strings.HasPrefix(resp.Errors[0].String(), expectedErrorPrefix), reasoning)
}