From fd7d1d45a80e3c9e49ee24c0505968f770f2ee27 Mon Sep 17 00:00:00 2001 From: Achilleas Koutsou Date: Thu, 11 May 2023 19:54:49 +0200 Subject: [PATCH] distro/fedora: remove test for empty ostree ref The ImageType.PackageSets() function is going away and instead we will rely on the ImageType.Manifest() function to both prepare the manifest and return the package sets. The Manifest() function should never be called without an ostree ref for ostree type images. --- internal/distro/fedora/distro_test.go | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/internal/distro/fedora/distro_test.go b/internal/distro/fedora/distro_test.go index 93f493122..9e73c41d4 100644 --- a/internal/distro/fedora/distro_test.go +++ b/internal/distro/fedora/distro_test.go @@ -786,24 +786,3 @@ func TestDistro_CustomUsrPartitionNotLargeEnough(t *testing.T) { } } } - -func TestIotInstallerWithoutOStreeRefs(t *testing.T) { - // Regression test for https://github.com/osbuild/osbuild-composer/issues/3125 - - // TODO: Remove when the ugly workaround is gone - d := fedora.NewF38() - arch, err := d.GetArch("x86_64") - require.NoError(t, err) - - imgType, err := arch.GetImageType("iot-installer") - require.NoError(t, err) - - bp := blueprint.Blueprint{ - Name: "fish", - } - err = bp.Initialize() - require.NoError(t, err) - - sets := imgType.PackageSets(bp, distro.ImageOptions{}, nil) - require.NotZero(t, len(sets)) -}