tag v0.165.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.165.0
----------------
* distro: move rhel9 into a generic distro (osbuild/images#1645)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* Revert "distro: drop `ImageType.BasePartitionTable()`" (osbuild/images#1691)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update dependencies 2025-07-20 (osbuild/images#1675)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* defs: add missing `bootstrap_containers` (osbuild/images#1679)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* disk: handle adding `PReP` partition on PPC64/s390x (HMS-8884) (osbuild/images#1681)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: bring per-distro checkOptions back (osbuild/images#1678)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: cleanups in the pkg/distro/generic area (osbuild/images#1686)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro: move rhel8 into a generic distro (osbuild/images#1643)
* Author: Michael Vogt, Reviewers: Nobody
* distro: small followups for PR#1682 (osbuild/images#1689)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* distro: unify transform/match into a single concept (osbuild/images#1682)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distros: de-duplicate runner build packages for centos10 (osbuild/images#1680)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* github: disable Go dep updates through dependabot (osbuild/images#1683)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* repos: include almalinux 9.6 (osbuild/images#1677)
* Author: Simon de Vlieger, Reviewers: Lukáš Zapletal, Tomáš Hozza
* rhel9: wsl distribution config (osbuild/images#1694)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers
* test/manifests/all-customizations: don't embed local file via URI (osbuild/images#1684)
* Author: Tomáš Hozza, Reviewers: Achilleas Koutsou, Brian C. Lane
— Somewhere on the Internet, 2025-07-28
---
tag v0.166.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.166.0
----------------
* customizations/subscription: conditionally enable semanage call (HMS-8866) (osbuild/images#1673)
* Author: Sanne Raymaekers, Reviewers: Achilleas Koutsou, Michael Vogt
* distro/rhel-10: versionlock shim-x64 in the azure-cvm image (osbuild/images#1697)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Simon de Vlieger
* manifestmock: move container/pkg/commit mocks into helper (osbuild/images#1700)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* rhel9: `vagrant-libvirt`, `vagrant-virtualbox` (osbuild/images#1693)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Sanne Raymaekers
* rhel{9,10}: centos WSL refinement (HMS-8922) (osbuild/images#1690)
* Author: Simon de Vlieger, Reviewers: Ondřej Budai, Sanne Raymaekers, Tomáš Hozza
— Somewhere on the Internet, 2025-07-29
---
tag v0.167.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.167.0
----------------
* RHEL/Azure: drop obsolete WAAgentConfig keys [RHEL-93894] and remove loglevel kernel option [RHEL-102372] (osbuild/images#1611)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Sanne Raymaekers
* Update dependencies 2025-07-27 (osbuild/images#1699)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro/rhel9: set default_kernel to kernel-uki-virt (osbuild/images#1704)
* Author: Achilleas Koutsou, Reviewers: Ondřej Budai, Simon de Vlieger
* distro: drop legacy loaders and update tests (osbuild/images#1687)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Tomáš Hozza
* distro: fix issues with yaml distro definitions and enable yaml checks (osbuild/images#1702)
* Author: Achilleas Koutsou, Reviewers: Michael Vogt, Ondřej Budai, Simon de Vlieger
— Somewhere on the Internet, 2025-07-30
---
tag v0.168.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.168.0
----------------
* distro: fix bug in variable substitution for static distros (osbuild/images#1710)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* rhel{9,10}: azure for non-RHEL (HMS-8949) (osbuild/images#1707)
* Author: Simon de Vlieger, Reviewers: Achilleas Koutsou, Michael Vogt
— Somewhere on the Internet, 2025-07-30
---
We have an issue where `%post` scripts are not being executed due to our incorrect handling of Anaconda modules [1].
[1]: https://github.com/osbuild/bootc-image-builder/issues/968
Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
tag v0.155.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.155.0
----------------
* Fedora 43: add shadow-utils when LockRoot is enabled, update cloud-init service name (osbuild/images#1618)
* Author: Achilleas Koutsou, Reviewers: Gianluca Zuccarelli, Michael Vogt
* Update osbuild dependency commit ID to latest (osbuild/images#1609)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza
* Update snapshots to 20250626 (osbuild/images#1623)
* Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger
* distro/rhel9: xz compress azure-cvm image type [HMS-8587] (osbuild/images#1620)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro/rhel: introduce new image type: Azure SAP Apps [HMS-8738] (osbuild/images#1612)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro/rhel: move ansible-core to sap_extras_pkgset (osbuild/images#1624)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza
* github/create-tag: allow passing the version when run manually (osbuild/images#1621)
* Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza
* rhel9: move image-config into pure YAML (HMS-8593) (osbuild/images#1616)
* Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger
* test: split manifest checksums into separate files (osbuild/images#1625)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
— Somewhere on the Internet, 2025-06-30
---
tag v0.156.0
Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com>
Changes with 0.156.0
----------------
* Many: delete repositories for EOL distributions (HMS-7044) (osbuild/images#1607)
* Author: Tomáš Hozza, Reviewers: Michael Vogt, Simon de Vlieger
* RHSM/facts: add 'image-builder CLI' API type (osbuild/images#1640)
* Author: Tomáš Hozza, Reviewers: Brian C. Lane, Simon de Vlieger
* Update dependencies 2025-06-29 (osbuild/images#1628)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* Update osbuild dependency commit ID to latest (osbuild/images#1627)
* Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza
* [RFC] image: drop `InstallWeakDeps` from image.DiskImage (osbuild/images#1642)
* Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza
* build(deps): bump the go-deps group across 1 directory with 3 updates (osbuild/images#1632)
* Author: dependabot[bot], Reviewers: SchutzBot, Tomáš Hozza
* distro/rhel10: xz compress azure-cvm image type (osbuild/images#1638)
* Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger
* distro: cleanup/refactor distro/{defs,generic} (HMS-8744) (osbuild/images#1570)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: remove some hardcoded values from generic/images.go (osbuild/images#1636)
* Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza
* distro: small tweaks for the YAML based imagetypes (osbuild/images#1622)
* Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger
* fedora/wsl: packages and locale (osbuild/images#1635)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* image/many: make compression more generic (osbuild/images#1634)
* Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt
* manifest: handle content template name with spaces (osbuild/images#1641)
* Author: Bryttanie, Reviewers: Brian C. Lane, Michael Vogt, Tomáš Hozza
* many: implement gzip (osbuild/images#1633)
* Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza
* rhel/azure: set GRUB_TERMINAL based on architecture [RHEL-91383] (osbuild/images#1626)
* Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza
— Somewhere on the Internet, 2025-07-07
---
Update the osbuild/images to the version which introduces "dot notation"
for distro release versions.
- Replace all uses of distroregistry by distrofactory.
- Delete local version of reporegistry and use the one from the
osbuild/images.
- Weldr: unify `createWeldrAPI()` and `createWeldrAPI2()` into a single
`createTestWeldrAPI()` function`.
- store/fixture: rework fixtures to allow overriding the host distro
name and host architecture name. A cleanup function to restore the
host distro and arch names is always part of the fixture struct.
- Delete `distro_mock` package, since it is no longer used.
- Bump the required version of osbuild to 98, because the OSCAP
customization is using the 'compress_results' stage option, which is
not available in older versions of osbuild.
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Update the images dependency to v0.18.0
This includes a change in the Fedora IoT remote configuration which is
now installed through an RPM instead of being hard-coded in the image
definitions.
https://github.com/Azure/azure-storage-blob-go/ is deprecated, the main SDK
should be now used instead. Let's migrate the code. There should be no
functional changes.
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Fedora 35 support was dropped, so we can update to a newer Go.
Stable RHEL 8 and 9 and Fedora 36 ships Go 1.18, so let's switch to it.
"//go:build" directives are now apparently enforced by go fmt, so that's why
there were added.
Also, all the github actions were adjusted to use Go 1.18.
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Version 5.22 introduced a new option to /etc/containers/policy.json called
keyPaths, see
https://github.com/containers/image/pull/1609
EL9 immediately took advantage of this new feature and started using it, see
04645c4a84
This quickly became an issue in our code: The go library (containers/image)
parses the configuration file very strictly and refuses to create a client
when policy.json with an unknown key is present on the filesystem. As we
used 5.21.1 that doesn't know the new key, our unit tests started to
failing when containers-common was present.
Reproducer:
podman run --pull=always --rm -it centos:stream9
dnf install -y dnf-plugins-core
dnf config-manager --set-enabled crb
dnf install -y gpgme-devel libassuan-devel krb5-devel golang git-core
git clone https://github.com/osbuild/osbuild-composer
cd osbuild-composer
# install the new containers-common and run the test
dnf install -y https://kojihub.stream.centos.org/kojifiles/packages/containers-common/1/44.el9/x86_64/containers-common-1-44.el9.x86_64.rpm
go test -count 1 ./...
# this returns:
--- FAIL: TestClientResolve (0.00s)
client_test.go:31:
Error Trace: client_test.go:31
Error: Received unexpected error:
Unknown key "keyPaths"
invalid policy in "/etc/containers/policy.json"
github.com/containers/image/v5/signature.NewPolicyFromFile
/osbuild-composer/vendor/github.com/containers/image/v5/signature/policy_config.go:88
github.com/osbuild/osbuild-composer/internal/container.NewClient
/osbuild-composer/internal/container/client.go:123
github.com/osbuild/osbuild-composer/internal/container_test.TestClientResolve
/osbuild-composer/internal/container/client_test.go:29
testing.tRunner
/usr/lib/golang/src/testing/testing.go:1439
runtime.goexit
/usr/lib/golang/src/runtime/asm_amd64.s:1571
Test: TestClientResolve
client_test.go:32:
Error Trace: client_test.go:32
Error: Expected value not to be nil.
Test: TestClientResolve
When run with an older containers-common, it succeeds:
dnf install -y https://kojihub.stream.centos.org/kojifiles/packages/containers-common/1/40.el9/x86_64/containers-common-1-40.el9.x86_64.rpm
go test -count 1 ./...
PASS
To sum it up, I had to upgrade github.com/containers/image/v5 to v5.22.0.
Unfortunately, this wasn't so simple, see
go get github.com/containers/image/v5@latest
go: github.com/containers/image/v5@v5.22.0 requires
github.com/letsencrypt/boulder@v0.0.0-20220331220046-b23ab962616e requires
github.com/honeycombio/beeline-go@v1.1.1 requires
github.com/gobuffalo/pop/v5@v5.3.1 requires
github.com/mattn/go-sqlite3@v2.0.3+incompatible: reading github.com/mattn/go-sqlite3/go.mod at revision v2.0.3: unknown revision v2.0.3
It turns out that github.com/mattn/go-sqlite3@v2.0.3+incompatible has been
recently retracted https://github.com/mattn/go-sqlite3/pull/998 and this
broke a ton of packages depending on it. I was able to fix it by adding
exclude github.com/mattn/go-sqlite3 v2.0.3+incompatible
to our go.mod, see
https://github.com/mattn/go-sqlite3/issues/975#issuecomment-955661657
After adding it,
go get github.com/containers/image/v5@latest
succeeded and tools/prepare-source.sh took care of the rest.
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Add a new generic container registry client via a new `container`
package. Use this to create a command line utility as well as a
new upload target for container registries.
The code uses the github.com/containers/* project and packages to
interact with container registires that is also used by skopeo,
podman et al. One if the dependencies is `proglottis/gpgme` that
is using cgo to bind libgpgme, so we have to add the corresponding
devel package to the BuildRequires as well as installing it on CI.
Checks will follow later via an integration test.
Fedora 33 and rawhide got an updated version of the azblob library. Sadly, it
introduced a non-compatible API change. This commit does the same thing as
a67baf5a did for kolo/xmlrpc:
We now have two wrappers around the affected part of the API. Fedora 32 uses
the wrapper around the old API, whereas Fedora 33 and 34 (and RHEL with its
vendored deps) use the wrapper around the new API. The switch is implemented
using go build flags and spec file magic.
See a67baf5a for more thoughts.
Also, there's v0.11.1-0.20201209121048-6df5d9af221d in go.mod, why?
The maintainers of azblob probably tagged a wrong commit with v0.12.0 which
breaks go. The long v0.11.1-.* version is basically the proper v0.12.0 commit.
See https://github.com/Azure/azure-storage-blob-go/issues/236 for more
information.
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Write an openapi spec for the worker API and use `deepmap/oapi-codegen`
to generate scaffolding for the server-side using the `labstack/echo`
server.
Incidentally, echo by default returns the errors in the same format that
worker API always has:
{ "message": "..." }
The API itself is unchanged to make this change easier to understand. It
will be changed to better suit our needs in future commits.
RHEL requires the source code for dependencies to be included in the
srpm. The spec file already expects that, but we've only included the
vendored modules (i.e., the `vendor` directory) in the `rhel-8.2.`
branch. Move vendoring to master, so that we can build RHEL packages
from it as well.
This commit is the result of running `go mod vendor`, which includes the
vendored sources and updates go.mod and go.sum files.
Fedora requires the opposite: dependencies should not be vendored. The
spec file already ignores the `vendor` directory by default.
