Commit graph

5 commits

Author SHA1 Message Date
Alexander Todorov
75a80c9625 Tell CodeCov to add comments to PRs 2024-05-10 22:08:27 +03:00
Lars Karlitski
0ad7843dad codevoc: fix threshold
d49f0fef4 added a 5% threshold to codecov.yml, so that small fixes don't
turn the CI red.

However, it contained a typo and put the setting in the wrong place in
the file. codecov.io ignores unknown keys instead of throwing an error.

Fix this and validate with:

    cat codecov.yml | curl --data-binary @- https://codecov.io/validate
2020-05-17 10:12:06 +02:00
Lars Karlitski
d49f0fef44 codecov: add 5% threshold
We're only using code coverage as additional information. Put in a 5%
threshold so that small fixes that decrease coverage slightly don't
block pull requests.
2020-05-12 21:38:43 +02:00
Lars Karlitski
6bf31423a2 codecov: disable codecov/patch status
Codecov's patch status measures lines covered in a given pull request,
which fails when moving code around.

Adding code with no coverage still fails the codecov/project status,
which fails if coverage has gone down.
2020-04-08 22:26:45 +02:00
Lars Karlitski
144570026d .github: switch to codecov.io
coveralls doesn't work from GitHub actions. Its "github" service type
uses the GITHUB_TOKEN from the action, which only has read access when
invoked from a forked repository.

codecov gets this right: it validates that an uploaded coverage file
originated from a GitHub action run by asking GitHub, and then uses its
OAuth credentials (through the Marketplace App) to comment and set
status.

Also, coveralls requires a third-party package to convert go's coverage
report to a format it understands. codecov detects the format
server-side. It also handles go's coverage format better: it highlights
lines with "some coverage" in yellow (coveralls has no concept of this).
2020-03-30 20:43:34 +02:00