tag v0.155.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.155.0 ---------------- * Fedora 43: add shadow-utils when LockRoot is enabled, update cloud-init service name (osbuild/images#1618) * Author: Achilleas Koutsou, Reviewers: Gianluca Zuccarelli, Michael Vogt * Update osbuild dependency commit ID to latest (osbuild/images#1609) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza * Update snapshots to 20250626 (osbuild/images#1623) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro/rhel9: xz compress azure-cvm image type [HMS-8587] (osbuild/images#1620) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * distro/rhel: introduce new image type: Azure SAP Apps [HMS-8738] (osbuild/images#1612) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * distro/rhel: move ansible-core to sap_extras_pkgset (osbuild/images#1624) * Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza * github/create-tag: allow passing the version when run manually (osbuild/images#1621) * Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza * rhel9: move image-config into pure YAML (HMS-8593) (osbuild/images#1616) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * test: split manifest checksums into separate files (osbuild/images#1625) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-06-30 --- tag v0.156.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.156.0 ---------------- * Many: delete repositories for EOL distributions (HMS-7044) (osbuild/images#1607) * Author: Tomáš Hozza, Reviewers: Michael Vogt, Simon de Vlieger * RHSM/facts: add 'image-builder CLI' API type (osbuild/images#1640) * Author: Tomáš Hozza, Reviewers: Brian C. Lane, Simon de Vlieger * Update dependencies 2025-06-29 (osbuild/images#1628) * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza * Update osbuild dependency commit ID to latest (osbuild/images#1627) * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza * [RFC] image: drop `InstallWeakDeps` from image.DiskImage (osbuild/images#1642) * Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza * build(deps): bump the go-deps group across 1 directory with 3 updates (osbuild/images#1632) * Author: dependabot[bot], Reviewers: SchutzBot, Tomáš Hozza * distro/rhel10: xz compress azure-cvm image type (osbuild/images#1638) * Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger * distro: cleanup/refactor distro/{defs,generic} (HMS-8744) (osbuild/images#1570) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: remove some hardcoded values from generic/images.go (osbuild/images#1636) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: small tweaks for the YAML based imagetypes (osbuild/images#1622) * Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger * fedora/wsl: packages and locale (osbuild/images#1635) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza * image/many: make compression more generic (osbuild/images#1634) * Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt * manifest: handle content template name with spaces (osbuild/images#1641) * Author: Bryttanie, Reviewers: Brian C. Lane, Michael Vogt, Tomáš Hozza * many: implement gzip (osbuild/images#1633) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza * rhel/azure: set GRUB_TERMINAL based on architecture [RHEL-91383] (osbuild/images#1626) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-07-07 ---
202 lines
6.8 KiB
Go
202 lines
6.8 KiB
Go
// Copyright 2014 Google LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package storage
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
"net/url"
|
|
"os"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"cloud.google.com/go/internal"
|
|
"cloud.google.com/go/internal/version"
|
|
sinternal "cloud.google.com/go/storage/internal"
|
|
"github.com/google/uuid"
|
|
gax "github.com/googleapis/gax-go/v2"
|
|
"github.com/googleapis/gax-go/v2/callctx"
|
|
"google.golang.org/api/googleapi"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
)
|
|
|
|
var defaultRetry *retryConfig = &retryConfig{}
|
|
var xGoogDefaultHeader = fmt.Sprintf("gl-go/%s gccl/%s", version.Go(), sinternal.Version)
|
|
|
|
const (
|
|
xGoogHeaderKey = "x-goog-api-client"
|
|
idempotencyHeaderKey = "x-goog-gcs-idempotency-token"
|
|
cookieHeaderKey = "cookie"
|
|
directpathCookieHeaderKey = "x-directpath-tracing-cookie"
|
|
)
|
|
|
|
var (
|
|
cookieHeader = sync.OnceValue(func() string {
|
|
return os.Getenv("GOOGLE_SDK_GO_TRACING_COOKIE")
|
|
})
|
|
)
|
|
|
|
func (r *retryConfig) runShouldRetry(err error) bool {
|
|
if r == nil || r.shouldRetry == nil {
|
|
return ShouldRetry(err)
|
|
}
|
|
return r.shouldRetry(err)
|
|
}
|
|
|
|
// run determines whether a retry is necessary based on the config and
|
|
// idempotency information. It then calls the function with or without retries
|
|
// as appropriate, using the configured settings.
|
|
func run(ctx context.Context, call func(ctx context.Context) error, retry *retryConfig, isIdempotent bool) error {
|
|
attempts := 1
|
|
invocationID := uuid.New().String()
|
|
|
|
if retry == nil {
|
|
retry = defaultRetry
|
|
}
|
|
if (retry.policy == RetryIdempotent && !isIdempotent) || retry.policy == RetryNever {
|
|
ctxWithHeaders := setInvocationHeaders(ctx, invocationID, attempts)
|
|
return call(ctxWithHeaders)
|
|
}
|
|
bo := gax.Backoff{}
|
|
if retry.backoff != nil {
|
|
bo.Multiplier = retry.backoff.Multiplier
|
|
bo.Initial = retry.backoff.Initial
|
|
bo.Max = retry.backoff.Max
|
|
}
|
|
|
|
var quitAfterTimer *time.Timer
|
|
if retry.maxRetryDuration != 0 {
|
|
quitAfterTimer = time.NewTimer(retry.maxRetryDuration)
|
|
defer quitAfterTimer.Stop()
|
|
}
|
|
|
|
var lastErr error
|
|
return internal.Retry(ctx, bo, func() (stop bool, err error) {
|
|
if retry.maxRetryDuration != 0 {
|
|
select {
|
|
case <-quitAfterTimer.C:
|
|
if lastErr == nil {
|
|
return true, fmt.Errorf("storage: request not sent, choose a larger value for the retry deadline (currently set to %s)", retry.maxRetryDuration)
|
|
}
|
|
return true, fmt.Errorf("storage: retry deadline of %s reached after %v attempts; last error: %w", retry.maxRetryDuration, attempts, lastErr)
|
|
default:
|
|
}
|
|
}
|
|
|
|
ctxWithHeaders := setInvocationHeaders(ctx, invocationID, attempts)
|
|
lastErr = call(ctxWithHeaders)
|
|
if lastErr != nil && retry.maxAttempts != nil && attempts >= *retry.maxAttempts {
|
|
return true, fmt.Errorf("storage: retry failed after %v attempts; last error: %w", *retry.maxAttempts, lastErr)
|
|
}
|
|
attempts++
|
|
retryable := retry.runShouldRetry(lastErr)
|
|
// Explicitly check context cancellation so that we can distinguish between a
|
|
// DEADLINE_EXCEEDED error from the server and a user-set context deadline.
|
|
// Unfortunately gRPC will codes.DeadlineExceeded (which may be retryable if it's
|
|
// sent by the server) in both cases.
|
|
if ctxErr := ctx.Err(); errors.Is(ctxErr, context.Canceled) || errors.Is(ctxErr, context.DeadlineExceeded) {
|
|
retryable = false
|
|
}
|
|
return !retryable, lastErr
|
|
})
|
|
}
|
|
|
|
// Sets invocation ID headers on the context which will be propagated as
|
|
// headers in the call to the service (for both gRPC and HTTP).
|
|
func setInvocationHeaders(ctx context.Context, invocationID string, attempts int) context.Context {
|
|
invocationHeader := fmt.Sprintf("gccl-invocation-id/%v gccl-attempt-count/%v", invocationID, attempts)
|
|
xGoogHeader := strings.Join([]string{invocationHeader, xGoogDefaultHeader}, " ")
|
|
|
|
ctx = callctx.SetHeaders(ctx, xGoogHeaderKey, xGoogHeader)
|
|
ctx = callctx.SetHeaders(ctx, idempotencyHeaderKey, invocationID)
|
|
|
|
if c := cookieHeader(); c != "" {
|
|
ctx = callctx.SetHeaders(ctx, cookieHeaderKey, c)
|
|
ctx = callctx.SetHeaders(ctx, directpathCookieHeaderKey, c)
|
|
}
|
|
|
|
return ctx
|
|
}
|
|
|
|
// ShouldRetry returns true if an error is retryable, based on best practice
|
|
// guidance from GCS. See
|
|
// https://cloud.google.com/storage/docs/retry-strategy#go for more information
|
|
// on what errors are considered retryable.
|
|
//
|
|
// If you would like to customize retryable errors, use the WithErrorFunc to
|
|
// supply a RetryOption to your library calls. For example, to retry additional
|
|
// errors, you can write a custom func that wraps ShouldRetry and also specifies
|
|
// additional errors that should return true.
|
|
func ShouldRetry(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
if errors.Is(err, io.ErrUnexpectedEOF) {
|
|
return true
|
|
}
|
|
if errors.Is(err, net.ErrClosed) {
|
|
return true
|
|
}
|
|
|
|
switch e := err.(type) {
|
|
case *googleapi.Error:
|
|
// Retry on 408, 429, and 5xx, according to
|
|
// https://cloud.google.com/storage/docs/exponential-backoff.
|
|
return e.Code == 408 || e.Code == 429 || (e.Code >= 500 && e.Code < 600)
|
|
case *net.OpError, *url.Error:
|
|
// Retry socket-level errors ECONNREFUSED and ECONNRESET (from syscall).
|
|
// Unfortunately the error type is unexported, so we resort to string
|
|
// matching.
|
|
retriable := []string{"connection refused", "connection reset", "broken pipe"}
|
|
for _, s := range retriable {
|
|
if strings.Contains(e.Error(), s) {
|
|
return true
|
|
}
|
|
}
|
|
// TODO: remove when https://github.com/golang/go/issues/53472 is resolved.
|
|
// We don't want to retry io.EOF errors, since these can indicate normal
|
|
// functioning terminations such as internally in the case of Reader and
|
|
// externally in the case of iterator methods. However, the linked bug
|
|
// requires us to retry the EOFs that it causes, which should be wrapped
|
|
// in net or url errors.
|
|
if errors.Is(err, io.EOF) {
|
|
return true
|
|
}
|
|
case *net.DNSError:
|
|
if e.IsTemporary {
|
|
return true
|
|
}
|
|
case interface{ Temporary() bool }:
|
|
if e.Temporary() {
|
|
return true
|
|
}
|
|
}
|
|
// UNAVAILABLE, RESOURCE_EXHAUSTED, INTERNAL, and DEADLINE_EXCEEDED codes are all retryable for gRPC.
|
|
if st, ok := status.FromError(err); ok {
|
|
if code := st.Code(); code == codes.Unavailable || code == codes.ResourceExhausted || code == codes.Internal || code == codes.DeadlineExceeded {
|
|
return true
|
|
}
|
|
}
|
|
// Unwrap is only supported in go1.13.x+
|
|
if e, ok := err.(interface{ Unwrap() error }); ok {
|
|
return ShouldRetry(e.Unwrap())
|
|
}
|
|
return false
|
|
}
|