a67baf5a4d
Fedora 33 ships the new API so let's do the switch now. But... this would break older Fedoras because they only have the old API, right? We have the following options: 1) Ship xmlrpc compat package to Fedora 33+. This would mean that we delay the API switch till F32 EOL. This would be the most elegant solution, yet it has two issues: a) We will surely not be able to deliver the compat package before F33 Final Freeze. b) It's an extra and annoying work. 2) Downstream patch. No. 3) Use build constraints and have two versions of our code for both different API. I chose solution #3. It has an issue though: %gobuild macro already passes -tags argument to go build. Therefore the following line fails because it's not possible to use -tags more than once: %gobuild -tags kolo_xmlrpc_oldapi ... Therefore I had to come up with manual tinkering with the build constraints in the spec file. This is pretty ugly but I like that: 1) Go code is actually clean, no weird magic is happening there. 2) We can still ship our software to Fedora/RHEL as we used to (no downstream patches) 3) All downstreams can use the upstream spec file directly. Note that this doesn't affect RHEL in any way as it uses vendored libraries. |
||
|---|---|---|
| .. | ||
| koji.go | ||
| koji_test.go | ||
| README.md | ||
| xmlrpc-response-oldapi.go | ||
| xmlrpc-response.go | ||
How to run the Koji test
Firstly, you need to start the koji container:
sudo ./tools/run-koji-container.sh start
This command starts a kojihub instance available at http://localhost:8080/kojihub . You can test that it started successfully by running:
koji --server=http://localhost:8080/kojihub --user=osbuild --password=osbuildpass --authtype=password hello
Now, you can run the koji test using:
go test -v -tags koji_test ./internal/upload/koji
The test is run on each PR in the Github CI. See .github/workflows/tests.yml
for more details.
To stop and remove the koji container, use the following command:
sudo ./tools/koji/run-koji-container.sh stop