1b169a150c
Imagine this scenario: the packer job is ran, an AMI gets created. We configure our deployment to use this AMI. Then, someone retries the packer job. Since we have force_deregister=true, this will not only create a new AMI, but also remove the old one (because it has the same name). Thus, our deployment will get broken, because the source AMI no longer exists. This means that the ASG cannot replace any broken instances, and the secure instance feature gets absolutely broken because it cannot spawn new secure instances (they "inherit" the AMI ID from their parents). Let's remove force_deregister=true, so the AMI never gets replaced. This might cause some pipelines to start failing because they are rerunning the packer job for same commit (the GA pipeline currently). Let's fix those then, rerunning the packer job is just confusing. If this causes some unexpected issues, we can always resort to using unique AMI names (by appending a timestamp to their name), but having multiple AMIs with different names, but same tags will cause our terraform configuration to be reapplied everytime there's a rerun, which is also not great. |
||
|---|---|---|
| .. | ||
| dashboards | ||
| openshift | ||
| packer | ||
| .kube-linter-config.yml | ||
| composer.yml | ||
| README.md | ||