2070800244
osbuild output should be always JSON-parsable. However, if a user has a weird installation of osbuild, it can return malformed JSON. In this case, it's very hard to debug what happened because the worker doesn't provide any useful information. This commit adds the non-parsable osbuild output to the error so there's at least some clue in the logs what happened. Let me reiterate: In 99% these cases, this shouldn't be needed. It will give us some hints in these 1% cases though. You may want to ask if using json.Decoder isn't better because it doesn't buffer the input. However, it does buffer. Firstly, json.Decoder.Decode() buffers the whole JSON value (it contains kinda cool state machine to do it) and in the second run, it parses the buffer. Therefore, the only thing that this commit actually does is that it moves the buffer out of json.Decoder. Signed-off-by: Ondřej Budai <ondrej@budai.cz> |
||
|---|---|---|
| .. | ||
| jobimpl-koji-finalize.go | ||
| jobimpl-koji-init.go | ||
| jobimpl-osbuild-koji.go | ||
| jobimpl-osbuild.go | ||
| main.go | ||
| main_test.go | ||
| osbuild.go | ||