573b349f16
The usual convention to create new object is to prefix `New*` so this commit renames the `WorkerClientError`. Initially I thought it would be `NewWorkerClientError()` but looking at the package prefix it seems unneeded, i.e. `clienterrors.New()` already provides enough context it seems and it's the only error we construct. We could consider renaming it to `clienterror` (singular) too but that could be a followup. I would also like to make `clienterror.Error` implement the `error` interface but that should be a followup to make this (mechanical) rename trivial to review.
61 lines
1.4 KiB
Go
61 lines
1.4 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
|
|
"github.com/osbuild/images/pkg/container"
|
|
"github.com/osbuild/osbuild-composer/internal/worker"
|
|
"github.com/osbuild/osbuild-composer/internal/worker/clienterrors"
|
|
)
|
|
|
|
type ContainerResolveJobImpl struct {
|
|
AuthFilePath string
|
|
}
|
|
|
|
func (impl *ContainerResolveJobImpl) Run(job worker.Job) error {
|
|
logWithId := logrus.WithField("jobId", job.Id())
|
|
var args worker.ContainerResolveJob
|
|
err := job.Args(&args)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
result := worker.ContainerResolveJobResult{
|
|
Specs: make([]worker.ContainerSpec, len(args.Specs)),
|
|
}
|
|
|
|
logWithId.Infof("Resolving containers (%d)", len(args.Specs))
|
|
|
|
resolver := container.NewResolver(args.Arch)
|
|
resolver.AuthFilePath = impl.AuthFilePath
|
|
|
|
for _, s := range args.Specs {
|
|
resolver.Add(container.SourceSpec{s.Source, s.Name, nil, s.TLSVerify, false})
|
|
}
|
|
|
|
specs, err := resolver.Finish()
|
|
|
|
if err != nil {
|
|
result.JobError = clienterrors.New(clienterrors.ErrorContainerResolution, err.Error(), nil)
|
|
} else {
|
|
for i, spec := range specs {
|
|
result.Specs[i] = worker.ContainerSpec{
|
|
Source: spec.Source,
|
|
Name: spec.LocalName,
|
|
TLSVerify: spec.TLSVerify,
|
|
ImageID: spec.ImageID,
|
|
Digest: spec.Digest,
|
|
ListDigest: spec.ListDigest,
|
|
}
|
|
}
|
|
}
|
|
|
|
err = job.Update(&result)
|
|
if err != nil {
|
|
return fmt.Errorf("Error reporting job result: %v", err)
|
|
}
|
|
|
|
return nil
|
|
}
|