debian-forge-composer/cmd
Michael Vogt 61bf0c3235 osbuild-worker: do not use error in clienterror.Error.Details
This is an alternative/complementary fix for PR#4137. It is very
simple so should be uncontroverisal.

It fixes an issue that @schuellerf discovered, i.e. that when an error
interface is passed into clienterrors.Error.Details the details get
lost because the json.Marshaler will not know how to handler an
error interface.

To find the problematic uses of `error` a custom vet checker was
build in https://github.com/mvo5/osbuild-cvet. With that the
result is:
```
$ go run github.com/mvo5/osbuild-cvet@latest ./...
/home/mvogt/devel/osbuild/osbuild-composer/cmd/osbuild-worker/jobimpl-depsolve.go:93:26: do not pass 'error' to WorkerClientError() details, use error.Error() instead
/home/mvogt/devel/osbuild/osbuild-composer/cmd/osbuild-worker/jobimpl-osbuild.go:404:31: do not pass 'error' to WorkerClientError() details, use error.Error() instead
/home/mvogt/devel/osbuild/osbuild-composer/cmd/osbuild-worker/jobimpl-osbuild.go:519:31: do not pass 'error' to WorkerClientError() details, use error.Error() instead
/home/mvogt/devel/osbuild/osbuild-composer/cmd/osbuild-worker/jobimpl-osbuild.go:556:31: do not pass '[]error' to WorkerClientError() details, use []string instead
```
and once this commit is in no more errors.

Just like PR#4137 this is not perfect because it will not do a
recursive check for the passed argument.
2024-06-07 01:19:11 +02:00
..
gen-manifests cmd/gen-manifests: pass repoconfigs when serializing manifests 2024-04-17 10:27:08 +02:00
mock-dnf-json switch to images/pkg/dnfjson and remove internal copy 2024-02-20 15:55:47 +01:00
osbuild-auth-tests Remove old build tag comments 2023-03-07 09:22:23 -08:00
osbuild-composer Update 'rhel-9' distro alias to 'rhel-9.5' 2024-06-04 13:03:37 +02:00
osbuild-composer-cli-tests Update deprecated io/ioutil functions 2023-03-07 09:22:23 -08:00
osbuild-composer-dbjobqueue-tests Remove old build tag comments 2023-03-07 09:22:23 -08:00
osbuild-dnf-json-tests cmd/osbuild-dnf-json-tests: check repo configs 2024-04-17 10:27:08 +02:00
osbuild-image-tests Drop common.CurrentArch() in favor of osbuild/images 2024-01-26 11:32:34 +01:00
osbuild-jobsite-builder osbuild-jobsite-builder: disable http.Server timeouts 2024-03-21 17:08:07 +01:00
osbuild-jobsite-manager osbuild-jobsite-manager: clean up store archive after use 2024-03-21 15:20:52 +01:00
osbuild-koji Worker/koji-finalize: import osbuild manifest and log to Koji build 2023-09-27 12:39:28 +02:00
osbuild-koji-tests Worker/koji-finalize: import osbuild manifest and log to Koji build 2023-09-27 12:39:28 +02:00
osbuild-mock-openid-provider Update deprecated io/ioutil functions 2023-03-07 09:22:23 -08:00
osbuild-service-maintenance templates/openshift: split worker from composer maintenance 2024-04-25 17:32:21 +02:00
osbuild-store-dump cmd/osbuild-store-dump: pass repoconfigs when serializing manifests 2024-04-17 10:27:08 +02:00
osbuild-upload-aws AWS: extend target options with the AMI boot mode 2023-05-19 13:24:39 +02:00
osbuild-upload-azure azure: add an option to tag page blobs 2022-06-13 21:06:01 +02:00
osbuild-upload-container split: replace internal packages with images library 2023-07-10 21:11:19 +02:00
osbuild-upload-gcp build(deps): bump cloud.google.com/go/compute from 1.10.0 to 1.19.3 2023-05-22 11:51:42 +02:00
osbuild-upload-generic-s3 awscloud: add option to mark S3 object as public 2022-09-19 22:56:36 +02:00
osbuild-upload-oci internal/target: add OCI object storage target 2023-09-19 22:57:06 +02:00
osbuild-upload-pulp-ostree cmd: update the final message in osbuild-upload-pulp-ostree 2023-10-18 21:14:46 +02:00
osbuild-worker osbuild-worker: do not use error in clienterror.Error.Details 2024-06-07 01:19:11 +02:00
osbuild-worker-executor main: rework the way the mock logger is passed 2024-06-06 21:14:31 +02:00