14ebed46da
Automatically registering on `init()` is clever, but a bit too magical and easy to get wrong, because every binary must include all distros somewhere. Flip this inside out: distros now have a `New()`, which returns something that implements the `Distro` interface. The distro package explicitly creates all of them. This means that distros cannot import distro itself anymore, because go forbids import cycles. This only affected `InvalidOutputFormatError`. Return a generic error for now.
63 lines
1.9 KiB
Go
63 lines
1.9 KiB
Go
package distro_test
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io/ioutil"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/osbuild/osbuild-composer/internal/blueprint"
|
|
"github.com/osbuild/osbuild-composer/internal/distro"
|
|
"github.com/osbuild/osbuild-composer/internal/pipeline"
|
|
)
|
|
|
|
func TestDistro_Pipeline(t *testing.T) {
|
|
pipelinePath := "../../test/cases/"
|
|
fileInfos, err := ioutil.ReadDir(pipelinePath)
|
|
if err != nil {
|
|
t.Errorf("Could not read pipelines directory '%s': %v", pipelinePath, err)
|
|
}
|
|
for _, fileInfo := range fileInfos {
|
|
type compose struct {
|
|
Distro string `json:"distro"`
|
|
OutputFormat string `json:"output-format"`
|
|
Blueprint *blueprint.Blueprint `json:"blueprint"`
|
|
}
|
|
var tt struct {
|
|
Compose *compose `json:"compose"`
|
|
Pipeline *pipeline.Pipeline `json:"pipeline,omitempty"`
|
|
}
|
|
file, err := ioutil.ReadFile(pipelinePath + fileInfo.Name())
|
|
if err != nil {
|
|
t.Errorf("Colud not read test-case '%s': %v", fileInfo.Name(), err)
|
|
}
|
|
err = json.Unmarshal([]byte(file), &tt)
|
|
if err != nil {
|
|
t.Errorf("Colud not parse test-case '%s': %v", fileInfo.Name(), err)
|
|
}
|
|
if tt.Compose == nil || tt.Compose.Blueprint == nil {
|
|
t.Logf("Skipping '%s'.", fileInfo.Name())
|
|
continue
|
|
}
|
|
t.Run(tt.Compose.OutputFormat, func(t *testing.T) {
|
|
d := distro.New(tt.Compose.Distro)
|
|
if d == nil {
|
|
t.Errorf("unknown distro: %v", tt.Compose.Distro)
|
|
return
|
|
}
|
|
got, err := d.Pipeline(tt.Compose.Blueprint, tt.Compose.OutputFormat)
|
|
if (err != nil) != (tt.Pipeline == nil) {
|
|
t.Errorf("distro.Pipeline() error = %v", err)
|
|
return
|
|
}
|
|
if tt.Pipeline != nil {
|
|
if !reflect.DeepEqual(got, tt.Pipeline) {
|
|
// Without this the "difference" is just a list of pointers.
|
|
gotJson, _ := json.Marshal(got)
|
|
fileJson, _ := json.Marshal(tt.Pipeline)
|
|
t.Errorf("d.Pipeline() =\n%v,\nwant =\n%v", string(gotJson), string(fileJson))
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|