6db5a7d6a8
The method assert.GreaterOrEqual(t, a, b) asserts that a >= b, but the arguments were (expected, actual), which is the wrong way around since we want to assure that the actual size is at least the expected size, i.e. actual >= expected and thus the argument should be (actual, expected). The partition table size (pt.Size) is in sectors while our checks and customizations are in bytes, so we need to convert when comparing. Co-Authored-By: Achilleas Koutsou <achilleas@koutsou.net>
134 lines
3.5 KiB
Go
134 lines
3.5 KiB
Go
package disk_test
|
|
|
|
import (
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/osbuild/osbuild-composer/internal/blueprint"
|
|
"github.com/osbuild/osbuild-composer/internal/disk"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestDisk_DynamicallyResizePartitionTable(t *testing.T) {
|
|
mountpoints := []blueprint.FilesystemCustomization{
|
|
{
|
|
MinSize: 2147483648,
|
|
Mountpoint: "/usr",
|
|
},
|
|
}
|
|
pt := disk.PartitionTable{
|
|
UUID: "D209C89E-EA5E-4FBD-B161-B461CCE297E0",
|
|
Type: "gpt",
|
|
Partitions: []disk.Partition{
|
|
{
|
|
Size: 2048,
|
|
Bootable: true,
|
|
Type: disk.BIOSBootPartitionGUID,
|
|
UUID: disk.BIOSBootPartitionUUID,
|
|
},
|
|
{
|
|
Type: disk.FilesystemDataGUID,
|
|
UUID: disk.RootPartitionUUID,
|
|
Filesystem: &disk.Filesystem{
|
|
Type: "xfs",
|
|
Label: "root",
|
|
Mountpoint: "/",
|
|
FSTabOptions: "defaults",
|
|
FSTabFreq: 0,
|
|
FSTabPassNo: 0,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
var expectedSize uint64 = 2147483648
|
|
// math/rand is good enough in this case
|
|
/* #nosec G404 */
|
|
rng := rand.New(rand.NewSource(0))
|
|
pt, err := disk.CreatePartitionTable(mountpoints, 1024, &pt, rng)
|
|
assert.NoError(t, err)
|
|
assert.GreaterOrEqual(t, pt.SectorsToBytes(pt.Size), expectedSize)
|
|
}
|
|
|
|
// common partition table that use used by tests
|
|
var canonicalPartitionTable = disk.PartitionTable{
|
|
UUID: "D209C89E-EA5E-4FBD-B161-B461CCE297E0",
|
|
Type: "gpt",
|
|
Partitions: []disk.Partition{
|
|
{
|
|
Size: 2048,
|
|
Bootable: true,
|
|
Type: disk.BIOSBootPartitionGUID,
|
|
UUID: disk.BIOSBootPartitionUUID,
|
|
},
|
|
{
|
|
Size: 204800,
|
|
Type: disk.EFISystemPartitionGUID,
|
|
UUID: disk.EFISystemPartitionUUID,
|
|
Filesystem: &disk.Filesystem{
|
|
Type: "vfat",
|
|
UUID: disk.EFIFilesystemUUID,
|
|
Mountpoint: "/boot/efi",
|
|
FSTabOptions: "defaults,uid=0,gid=0,umask=077,shortname=winnt",
|
|
FSTabFreq: 0,
|
|
FSTabPassNo: 2,
|
|
},
|
|
},
|
|
{
|
|
Size: 1048576,
|
|
Type: disk.FilesystemDataGUID,
|
|
UUID: disk.FilesystemDataUUID,
|
|
Filesystem: &disk.Filesystem{
|
|
Type: "xfs",
|
|
Mountpoint: "/boot",
|
|
FSTabOptions: "defaults",
|
|
FSTabFreq: 0,
|
|
FSTabPassNo: 0,
|
|
},
|
|
},
|
|
{
|
|
Type: disk.FilesystemDataGUID,
|
|
UUID: disk.RootPartitionUUID,
|
|
Filesystem: &disk.Filesystem{
|
|
Type: "xfs",
|
|
Label: "root",
|
|
Mountpoint: "/",
|
|
FSTabOptions: "defaults",
|
|
FSTabFreq: 0,
|
|
FSTabPassNo: 0,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
func TestDisk_ForEachFilesystem(t *testing.T) {
|
|
rootFs := canonicalPartitionTable.Partitions[3].Filesystem
|
|
bootFs := canonicalPartitionTable.Partitions[2].Filesystem
|
|
efiFs := canonicalPartitionTable.Partitions[1].Filesystem
|
|
|
|
// check we iterate in the correct order and throughout the whole array
|
|
var expectedFilesystems []*disk.Filesystem
|
|
err := canonicalPartitionTable.ForEachFilesystem(func(fs *disk.Filesystem) error {
|
|
expectedFilesystems = append(expectedFilesystems, fs)
|
|
return nil
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []*disk.Filesystem{efiFs, bootFs, rootFs}, expectedFilesystems)
|
|
|
|
// check we stop iterating when the callback returns false
|
|
expectedFilesystems = make([]*disk.Filesystem, 0)
|
|
err = canonicalPartitionTable.ForEachFilesystem(func(fs *disk.Filesystem) error {
|
|
if fs.Mountpoint != "/boot" {
|
|
return nil
|
|
}
|
|
|
|
// we should stop at boot, never reaching root
|
|
assert.NotEqual(t, fs.Mountpoint, "/")
|
|
|
|
expectedFilesystems = append(expectedFilesystems, fs)
|
|
return disk.StopIter
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []*disk.Filesystem{bootFs}, expectedFilesystems)
|
|
}
|