tag v0.155.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.155.0 ---------------- * Fedora 43: add shadow-utils when LockRoot is enabled, update cloud-init service name (osbuild/images#1618) * Author: Achilleas Koutsou, Reviewers: Gianluca Zuccarelli, Michael Vogt * Update osbuild dependency commit ID to latest (osbuild/images#1609) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger, Tomáš Hozza * Update snapshots to 20250626 (osbuild/images#1623) * Author: SchutzBot, Reviewers: Achilleas Koutsou, Simon de Vlieger * distro/rhel9: xz compress azure-cvm image type [HMS-8587] (osbuild/images#1620) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * distro/rhel: introduce new image type: Azure SAP Apps [HMS-8738] (osbuild/images#1612) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza * distro/rhel: move ansible-core to sap_extras_pkgset (osbuild/images#1624) * Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Tomáš Hozza * github/create-tag: allow passing the version when run manually (osbuild/images#1621) * Author: Achilleas Koutsou, Reviewers: Lukáš Zapletal, Tomáš Hozza * rhel9: move image-config into pure YAML (HMS-8593) (osbuild/images#1616) * Author: Michael Vogt, Reviewers: Achilleas Koutsou, Simon de Vlieger * test: split manifest checksums into separate files (osbuild/images#1625) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-06-30 --- tag v0.156.0 Tagger: imagebuilder-bot <imagebuilder-bots+imagebuilder-bot@redhat.com> Changes with 0.156.0 ---------------- * Many: delete repositories for EOL distributions (HMS-7044) (osbuild/images#1607) * Author: Tomáš Hozza, Reviewers: Michael Vogt, Simon de Vlieger * RHSM/facts: add 'image-builder CLI' API type (osbuild/images#1640) * Author: Tomáš Hozza, Reviewers: Brian C. Lane, Simon de Vlieger * Update dependencies 2025-06-29 (osbuild/images#1628) * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza * Update osbuild dependency commit ID to latest (osbuild/images#1627) * Author: SchutzBot, Reviewers: Simon de Vlieger, Tomáš Hozza * [RFC] image: drop `InstallWeakDeps` from image.DiskImage (osbuild/images#1642) * Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger, Tomáš Hozza * build(deps): bump the go-deps group across 1 directory with 3 updates (osbuild/images#1632) * Author: dependabot[bot], Reviewers: SchutzBot, Tomáš Hozza * distro/rhel10: xz compress azure-cvm image type (osbuild/images#1638) * Author: Achilleas Koutsou, Reviewers: Brian C. Lane, Simon de Vlieger * distro: cleanup/refactor distro/{defs,generic} (HMS-8744) (osbuild/images#1570) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: remove some hardcoded values from generic/images.go (osbuild/images#1636) * Author: Michael Vogt, Reviewers: Simon de Vlieger, Tomáš Hozza * distro: small tweaks for the YAML based imagetypes (osbuild/images#1622) * Author: Michael Vogt, Reviewers: Brian C. Lane, Simon de Vlieger * fedora/wsl: packages and locale (osbuild/images#1635) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza * image/many: make compression more generic (osbuild/images#1634) * Author: Simon de Vlieger, Reviewers: Brian C. Lane, Michael Vogt * manifest: handle content template name with spaces (osbuild/images#1641) * Author: Bryttanie, Reviewers: Brian C. Lane, Michael Vogt, Tomáš Hozza * many: implement gzip (osbuild/images#1633) * Author: Simon de Vlieger, Reviewers: Michael Vogt, Tomáš Hozza * rhel/azure: set GRUB_TERMINAL based on architecture [RHEL-91383] (osbuild/images#1626) * Author: Achilleas Koutsou, Reviewers: Simon de Vlieger, Tomáš Hozza — Somewhere on the Internet, 2025-07-07 ---
140 lines
4.1 KiB
Go
140 lines
4.1 KiB
Go
package retry
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"math"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/containers/image/v5/docker"
|
|
"github.com/docker/distribution/registry/api/errcode"
|
|
errcodev2 "github.com/docker/distribution/registry/api/v2"
|
|
"github.com/hashicorp/go-multierror"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// Options defines the option to retry.
|
|
type Options struct {
|
|
MaxRetry int // The number of times to possibly retry.
|
|
Delay time.Duration // The delay to use between retries, if set.
|
|
IsErrorRetryable func(error) bool
|
|
}
|
|
|
|
// RetryOptions is deprecated, use Options.
|
|
type RetryOptions = Options // nolint:revive
|
|
|
|
// RetryIfNecessary deprecated function use IfNecessary.
|
|
func RetryIfNecessary(ctx context.Context, operation func() error, options *Options) error { // nolint:revive
|
|
return IfNecessary(ctx, operation, options)
|
|
}
|
|
|
|
// IfNecessary retries the operation in exponential backoff with the retry Options.
|
|
func IfNecessary(ctx context.Context, operation func() error, options *Options) error {
|
|
var isRetryable func(error) bool
|
|
if options.IsErrorRetryable != nil {
|
|
isRetryable = options.IsErrorRetryable
|
|
} else {
|
|
isRetryable = IsErrorRetryable
|
|
}
|
|
err := operation()
|
|
for attempt := 0; err != nil && isRetryable(err) && attempt < options.MaxRetry; attempt++ {
|
|
delay := time.Duration(int(math.Pow(2, float64(attempt)))) * time.Second
|
|
if options.Delay != 0 {
|
|
delay = options.Delay
|
|
}
|
|
logrus.Warnf("Failed, retrying in %s ... (%d/%d). Error: %v", delay, attempt+1, options.MaxRetry, err)
|
|
select {
|
|
case <-time.After(delay):
|
|
// Do nothing.
|
|
case <-ctx.Done():
|
|
return err
|
|
}
|
|
err = operation()
|
|
}
|
|
return err
|
|
}
|
|
|
|
// IsErrorRetryable makes a HEURISTIC determination whether it is worth retrying upon encountering an error.
|
|
// That heuristic is NOT STABLE and it CAN CHANGE AT ANY TIME.
|
|
// Callers that have a hard requirement for specific treatment of a class of errors should make their own check
|
|
// instead of relying on this function maintaining its past behavior.
|
|
func IsErrorRetryable(err error) bool {
|
|
switch err {
|
|
case nil:
|
|
return false
|
|
case context.Canceled, context.DeadlineExceeded:
|
|
return false
|
|
default: // continue
|
|
}
|
|
|
|
type unwrapper interface {
|
|
Unwrap() error
|
|
}
|
|
|
|
switch e := err.(type) {
|
|
case errcode.Error:
|
|
switch e.Code {
|
|
case errcode.ErrorCodeUnauthorized, errcode.ErrorCodeDenied,
|
|
errcodev2.ErrorCodeNameUnknown, errcodev2.ErrorCodeManifestUnknown:
|
|
return false
|
|
}
|
|
return true
|
|
case docker.UnexpectedHTTPStatusError:
|
|
// Retry on 502, 502 and 503 http server errors, they appear to be quite common in the field.
|
|
// https://github.com/containers/common/issues/2299
|
|
if e.StatusCode >= http.StatusBadGateway && e.StatusCode <= http.StatusGatewayTimeout {
|
|
return true
|
|
}
|
|
return false
|
|
case *net.OpError:
|
|
return IsErrorRetryable(e.Err)
|
|
case *url.Error: // This includes errors returned by the net/http client.
|
|
if e.Err == io.EOF { // Happens when a server accepts a HTTP connection and sends EOF
|
|
return true
|
|
}
|
|
return IsErrorRetryable(e.Err)
|
|
case syscall.Errno:
|
|
return isErrnoRetryable(e)
|
|
case errcode.Errors:
|
|
// if this error is a group of errors, process them all in turn
|
|
for i := range e {
|
|
if !IsErrorRetryable(e[i]) {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
case *multierror.Error:
|
|
// if this error is a group of errors, process them all in turn
|
|
for i := range e.Errors {
|
|
if !IsErrorRetryable(e.Errors[i]) {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
case net.Error:
|
|
if e.Timeout() {
|
|
return true
|
|
}
|
|
if unwrappable, ok := e.(unwrapper); ok {
|
|
err = unwrappable.Unwrap()
|
|
return IsErrorRetryable(err)
|
|
}
|
|
case unwrapper: // Test this last, because various error types might implement .Unwrap()
|
|
err = e.Unwrap()
|
|
return IsErrorRetryable(err)
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func isErrnoRetryable(e error) bool {
|
|
switch e {
|
|
case syscall.ECONNREFUSED, syscall.EINTR, syscall.EAGAIN, syscall.EBUSY, syscall.ENETDOWN, syscall.ENETUNREACH, syscall.ENETRESET, syscall.ECONNABORTED, syscall.ECONNRESET, syscall.ETIMEDOUT, syscall.EHOSTDOWN, syscall.EHOSTUNREACH:
|
|
return true
|
|
}
|
|
return isErrnoERESTART(e)
|
|
}
|