particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

devices/loopback: make setting sector_size meaningful

Browse source 
For the org.osbuild.loopback the user can set the sector size, but
it had no effect on the underlying loopback device. Let's make it
meaningful by passing along the given value to the underlying code.
This commit is contained in:
Dusty Mabe 2023-11-21 17:18:22 -05:00 • committed by Simon de Vlieger
parent 677a874115
commit 0770eb0090
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
osbuild/loop.py
View file

@ -385,7 +385,7 @@ class Loop:
info = self._config_info(self.get_status(), offset, sizelimit, autoclear, partscan)
fcntl.ioctl(self.fd, self.LOOP_SET_STATUS64, info)
def configure(self, fd: int, offset=None, sizelimit=None, autoclear=None, partscan=None):
def configure(self, fd: int, offset=None, sizelimit=None, blocksize=0, autoclear=None, partscan=None):
"""
Configure the loopback device
Bind and configure in a single operation a file descriptor to the
@ -427,6 +427,8 @@ class Loop:
sizelimit : int, optional
The max size in bytes to make the loopback device, or None
to leave unchanged (default is None)
blocksize : int, optional
Set the logical blocksize of the loopback device. Default is 0.
autoclear : bool, optional
Whether or not to enable autoclear, or None to leave unchanged
(default is None)
@ -437,9 +439,7 @@ class Loop:
# pylint: disable=attribute-defined-outside-init
config = LoopConfig()
config.fd = fd
# Previous implementation was not configuring the block size.
# Keep same behavior here by setting the value to 0.
config.block_size = 0
config.block_size = int(blocksize)
config.info = self._config_info(LoopInfo(), offset, sizelimit, autoclear, partscan)
try:
fcntl.ioctl(self.fd, self.LOOP_CONFIGURE, config)