particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Testutil/importlib: don't write bytecode when importing modules

Browse source 
Cache files will split the extension, this means that all pyc cache
files looks like we get many clashing `org.osbuild.cpython-py311.pyc
files. Moreover, the cache bytecode invalidation is based on the
timestamp (which is the same after git checkout) and the file size
(which may be the same for two different files). This means that we
can't rely on the cache files.

This issue has been found after the previous commit made the
`org.osbuild.systemd` and `org.osbuild.selinux` stages to have exactly
the same size, which caused the interpreter to reuse the bytecode for
the selinux stage when running unit tests for the systemd stage. This
resulted in consistent and weird failures when the systemd stage
options were passed to the selinux stage code.

The credit for this fix goes to Michael Vogt, who found the cause and
fix. Also thanks to Simon de Vlieger for his help with debugging the
problem.

Co-authored-by: Michael Vogt <michael.vogt@gmail.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This commit is contained in:
Tomáš Hozza 2024-04-22 14:36:21 +02:00 • committed by Achilleas Koutsou
parent 13c098cfdd
commit 3ae8f25f55
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
osbuild/testutil/imports.py
View file

@ -3,8 +3,16 @@
Import related utilities
"""
import importlib
import sys
from types import ModuleType
# Cache files will split the extension, this means that all pyc cache files
# looks like we get many clashing `org.osbuild.cpython-py311.pyc` files.
# Moreover, the cache bytecode invalidation is based on the timestamp (which
# is the same after git checkout) and the file size (which may be the same
# for two different files). This means that we can't rely on the cache files.
sys.dont_write_bytecode = True
def import_module_from_path(fullname, path: str) -> ModuleType:
"""import_module_from_path imports the given path as a python module