stages/sgdisk: option to not quote partition names passed to sgdisk
The partition name in the sgdisk stage was previously quoted when passed to sgdisk as an argument. I think that this was done because the sgdisk man page states that: ``` If you want to set a name that includes a space, enclose it in quotation marks, as in sgdisk -c 1:"Sample Name" /dev/sdb. ``` However, this should apply only when sgdisk is run in a shell, so that the argument is not split by shell into multiple arguments and passes as a single string. The stage is executing sgdisk using Python `subprocess` module, which does not need strings with spaces to be quoted, because they are passed to the command as separate items which are not split in any way. The previous behavior of the stage was that these quotes became part of the actual partition name in the partition table. After a discussion within the team, we determined that this is a bug. However, fixing it would result in osbuild producing a different artifact for the same manifest, compared to osbuild version without such fix. This is undesired. For backward compatibility, a new `quote_partition_name` property is added to the stage options, which can be used to make the stage not quote the partition name when passed to `sgdisk`. As a result, the partition name won't be quoted in the partition table. The default stage behavior us kept. Modify unit tests to use this option by default. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
This commit is contained in:
parent
267f3909bd
commit
3e780762cb
4 changed files with 16 additions and 7 deletions
|
|
@ -13,7 +13,7 @@
|
|||
"size": 1024000,
|
||||
"type": "C12A7328-F81F-11D2-BA4B-00A0C93EC93B",
|
||||
"uuid": "80B68AE7-3531-478C-A5FF-9B80F1CB07E9",
|
||||
"name": "\"EFI System Partition\"",
|
||||
"name": "EFI System Partition",
|
||||
"attrs": "LegacyBIOSBootable"
|
||||
},
|
||||
{
|
||||
|
|
@ -22,7 +22,7 @@
|
|||
"size": 1024000,
|
||||
"type": "BC13C2FF-59E6-4262-A352-B275FD6F7172",
|
||||
"uuid": "CFE2BEB6-0BB8-4FB6-9075-2E79413AB707",
|
||||
"name": "\"boot\"",
|
||||
"name": "boot",
|
||||
"attrs": "LegacyBIOSBootable"
|
||||
},
|
||||
{
|
||||
|
|
@ -31,7 +31,7 @@
|
|||
"size": 4096,
|
||||
"type": "FAC7F1FB-3E8D-4137-A512-961DE09A5549",
|
||||
"uuid": "6E2E131D-14C4-4278-876A-5067C40EAECD",
|
||||
"name": "\"BIOS boot\""
|
||||
"name": "BIOS boot"
|
||||
},
|
||||
{
|
||||
"node": "disk.img4",
|
||||
|
|
@ -39,7 +39,7 @@
|
|||
"size": 18917343,
|
||||
"type": "E6D6D379-F507-44C2-A23C-238F2A3DF928",
|
||||
"uuid": "646E1B09-9358-4A9C-B630-E3C0C296F7C6",
|
||||
"name": "\"LVM\""
|
||||
"name": "LVM"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
|
|||
|
|
@ -375,6 +375,7 @@
|
|||
},
|
||||
"options": {
|
||||
"uuid": "68ad7ade-3fa7-4844-8b2f-1c4cd30bef70",
|
||||
"quote_partition_name": false,
|
||||
"partitions": [
|
||||
{
|
||||
"uuid": "80b68ae7-3531-478c-a5ff-9b80f1cb07e9",
|
||||
|
|
|
|||
|
|
@ -31,6 +31,7 @@
|
|||
},
|
||||
"options": {
|
||||
"uuid": "68ad7ade-3fa7-4844-8b2f-1c4cd30bef70",
|
||||
"quote_partition_name": false,
|
||||
"partitions": [
|
||||
{
|
||||
"uuid": "80b68ae7-3531-478c-a5ff-9b80f1cb07e9",
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue