diff --git a/osbuild/main_cli.py b/osbuild/main_cli.py index f82153f0..21e38b9f 100644 --- a/osbuild/main_cli.py +++ b/osbuild/main_cli.py @@ -186,7 +186,6 @@ def osbuild_cli() -> int: debug_break, stage_timeout=stage_timeout ) - # TODO: this needs a test if r["success"]: monitor.log(f"manifest {args.manifest_path} finished successfully", origin="org.osbuild.main") else: @@ -197,8 +196,6 @@ def osbuild_cli() -> int: for pid in exports: export(pid, output_directory, object_store, manifest) - # TODO: subpress when "--monitor=JSONSeqMontior" is used - # or (be explcit) have "--no-summary" or something if args.json: r = fmt.output(manifest, r, object_store) json.dump(r, sys.stdout) diff --git a/osbuild/monitor.py b/osbuild/monitor.py index 4a24bd6b..80b4275a 100644 --- a/osbuild/monitor.py +++ b/osbuild/monitor.py @@ -335,7 +335,7 @@ class JSONSeqMonitor(BaseMonitor): # result is for modules def result(self, result: osbuild.pipeline.BuildResult): - # TODO: check pipeline id? + # we may need to check pipeline ids here in the future if self._progress.sub_progress: self._progress.sub_progress.incr() self.log(f"Finished module {result.name}", origin="org.osbuild.main")