particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

utils/mnt: fix mount permissions

Browse source 
This is a follow up to #1550 where we enabled a `rw` permissions mode,
which is not ideal since it would theoretically be possible to set both
`ro` and `rw` modes at the same time. This commit fixes the issue by only
allowing one option at a time.

Fixes #1588
This commit is contained in:
Gianluca Zuccarelli 2024-03-06 11:20:17 +00:00 • committed by Gianluca Zuccarelli
parent 2d2cdd8097
commit 6c0973238d
4 changed files with 25 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/mod/test_util_mnt.py
View file

@ -21,6 +21,14 @@ def test_mount_guard_failure_msg(tmp_path):
assert "special device /dev/invalid-src does not exist" in str(e.value)
@pytest.mark.skipif(os.getuid() != 0, reason="root only")
def test_mount_guard_incorrect_permissions_msg(tmp_path):
with pytest.raises(ValueError) as e:
with MountGuard() as mg:
mg.mount("/dev/invalid-src", tmp_path, permissions="abc")
assert "unknown filesystem permissions" in str(e.value)
# This needs a proper refactor so that FileSystemMountService just uses
# a common mount helper.
class FakeFileSystemMountService(FileSystemMountService):