particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

stages,test: update tests for new selinux.setfiles() calling

Browse source
This commit is contained in:
Michael Vogt 2024-01-04 15:28:43 +01:00
parent 467a23ffa7
commit 73ec3122f2
2 changed files with 26 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

22
stages/test/test_selinux.py
View file

@ -56,8 +56,8 @@ def test_schema_validation_selinux_file_context_required():
assert "'file_contexts' is a required property" in err_msgs[0]
@patch("subprocess.run")
def test_selinux_file_contexts(mocked_run, tmp_path):
@patch("osbuild.util.selinux.setfiles")
def test_selinux_file_contexts(mocked_setfiles, tmp_path):
stage_path = os.path.join(os.path.dirname(__file__), "../org.osbuild.selinux")
stage = import_module_from_path("stage", stage_path)
@ -66,17 +66,15 @@ def test_selinux_file_contexts(mocked_run, tmp_path):
}
stage.main(tmp_path, options)
assert len(mocked_run.call_args_list) == 1
assert mocked_run.call_args_list == [
call(
["setfiles", "-F", "-r", os.fspath(tmp_path),
f"{tmp_path}/etc/selinux/thing", os.fspath(tmp_path)], check=True),
assert len(mocked_setfiles.call_args_list) == 1
assert mocked_setfiles.call_args_list == [
call(f"{tmp_path}/etc/selinux/thing", os.fspath(tmp_path), "")
]
@patch("osbuild.util.selinux.setfilecon")
@patch("subprocess.run")
def test_selinux_labels(mocked_run, mocked_setfilecon, tmp_path):
@patch("osbuild.util.selinux.setfiles")
def test_selinux_labels(mocked_setfiles, mocked_setfilecon, tmp_path):
stage_path = os.path.join(os.path.dirname(__file__), "../org.osbuild.selinux")
stage = import_module_from_path("stage", stage_path)
@ -92,15 +90,15 @@ def test_selinux_labels(mocked_run, mocked_setfilecon, tmp_path):
}
stage.main(tmp_path, options)
assert len(mocked_run.call_args_list) == 1
assert len(mocked_setfiles.call_args_list) == 1
assert len(mocked_setfilecon.call_args_list) == 1
assert mocked_setfilecon.call_args_list == [
call(f"{tmp_path}/tree/usr/bin/bootc", "system_u:object_r:install_exec_t:s0"),
]
@patch("subprocess.run")
def test_selinux_force_autorelabel(mocked_run, tmp_path): # pylint: disable=unused-argument
@patch("osbuild.util.selinux.setfiles")
def test_selinux_force_autorelabel(mocked_setfiles, tmp_path): # pylint: disable=unused-argument
stage_path = os.path.join(os.path.dirname(__file__), "../org.osbuild.selinux")
stage = import_module_from_path("stage", stage_path)

16
test/mod/test_util_selinux.py
View file

@ -4,6 +4,7 @@
import errno
import io
import os
from unittest import mock
from osbuild.util import selinux
@ -58,3 +59,18 @@ def test_setfilecon():
setxattr.side_effect = raise_error
selinux.setfilecon("path", "context")
@mock.patch("subprocess.run")
def test_selinux_setfiles(mocked_run, tmp_path):
selinux.setfiles("/etc/selinux/thing", os.fspath(tmp_path), "/", "/boot")
assert len(mocked_run.call_args_list) == 2
assert mocked_run.call_args_list == [
mock.call(
["setfiles", "-F", "-r", os.fspath(tmp_path),
"/etc/selinux/thing", os.fspath(tmp_path) + "/"], check=True),
mock.call(
["setfiles", "-F", "-r", os.fspath(tmp_path),
"/etc/selinux/thing", os.fspath(tmp_path) + "/boot"], check=True),
]