particle-os/debian-forge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

buildroot: make var a positional argument

Browse source 
Commit d028ea5b16 introduced bug when introducing the `store`
argument to `Stage.run`, instead of passing `var=var`, i.e.
`var` is being passed as keyword argument, it is now being
passed as a positional one. Since the `path=/run/osbuild`
keyword argument comes before the `var=/var/tmp` argument,
`var` is now being passed as `path` instead of var.
Since `var` is always being passed in throughout the entire
codebase, make it a positional argument, and move it before
`path`.
Adapt the tests to pass `var` as positional argument.
This commit is contained in:
Christian Kellner 2021-02-11 20:46:33 +00:00
parent dd50387bbc
commit 749f59cc9a
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
osbuild/buildroot.py
View file

@ -59,7 +59,7 @@ class BuildRoot(contextlib.AbstractContextManager):
only when exiting the context manager.
"""
def __init__(self, root, runner, libdir, path="/run/osbuild", var="/var/tmp"):
def __init__(self, root, runner, libdir, var, path="/run/osbuild"):
self._exitstack = None
self._rootdir = root
self._rundir = path