From a860652ae1885296f6a63395ae2bee5defc46d5e Mon Sep 17 00:00:00 2001 From: Tomas Hozza Date: Thu, 14 Jan 2021 14:09:34 +0100 Subject: [PATCH] Makefile: mark '$(TEST_MANIFESTS_GEN)' target as .PHONY Mark '$(TEST_MANIFESTS_GEN)' target as .PHONY. Currently the `test-data` make target does not always trigger regenerating of manifests used for testing various osbuild parts, although it is marked as .PHONY. The reason that its dependency '$(TEST_MANIFESTS_GEN)' is not marked as .PHONY and therefore it is not run if the files already exist in repository. Due to the above reason, CI is actually running `make --always-make test-data` to always regenerate manifests. Signed-off-by: Tomas Hozza --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 91be8d95..8d54aaea 100644 --- a/Makefile +++ b/Makefile @@ -209,6 +209,7 @@ TEST_MANIFESTS_MPP = $(wildcard $(SRCDIR)/test/data/manifests/*.mpp.json) \ $(wildcard $(SRCDIR)/test/data/stages/*/*.mpp.json) TEST_MANIFESTS_GEN = $(TEST_MANIFESTS_MPP:%.mpp.json=%.json) +.PHONY: $(TEST_MANIFESTS_GEN) $(TEST_MANIFESTS_GEN): %.json: %.mpp.json $(SRCDIR)/tools/mpp-depsolve.py <"$<" \ | $(SRCDIR)/tools/mpp-import-pipeline.py >"$@" \